[NPMCLI-90] start command option for --ignore-open-files-limit Created: 31/Jan/17 Updated: 31/Jan/17 Resolved: 31/Jan/17 |
|
| Status: | Closed |
| Project: | Magnolia CLI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Unassigned |
| Resolution: | Not an issue | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
The start command should accept an argument to ignore the open files limit. The argument should be short or provide a one letter alias. For consistency, using the same "--ignore-open-files-limit" option as magnolia accepts would be a good choice. A possible alias would be "-i". This feature is important for demos, testing, workshops where it can be cumbersome to actually raise the open file limit on the system. |
| Comments |
| Comment by Federico Grilli [ 31/Jan/17 ] |
|
The opposite approach was taken, that is, ignore the check by default. Reason behind this is that, in my experience, ignoring the check has always been safe when developing on my Mac. Also, being stopped immediately by a warn when running mgnl start is rather annoying. $ mgnl start -h [...] snip -d, --dont-ignore-open-files-check Does not ignore the open files limit check (it is ignored by default). For more information, see https://documentation.magnolia-cms.com/display/DOCS/Known+issues#Knownissues-Toomanyopenfiles |