[PAGES-1017] Remove prefix website when using @name in routeTemplate of site norsu definition Created: 02/Feb/23 Updated: 14/Mar/23 Resolved: 08/Feb/23 |
|
| Status: | Closed |
| Project: | Magnolia pages module |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Oanh Thai Hoang | Assignee: | Canh Nguyen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | 0d | Remaining Estimate: | 0d |
| Σ Time Spent: | 4d 2.75h | Time Spent: | 3d 7.75h |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
|||||||||||||||||||||||||
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: | ||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
|||||||||||||||||||||||||
| Documentation update required: |
Yes
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | SaaS TPR - DevX Bugs | |||||||||||||||||||||||||
| Sprint: | DevX 30 | |||||||||||||||||||||||||
| Story Points: | 3 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Work Started: | ||||||||||||||||||||||||||
| Description |
|
Step to reproduce:
http://cooltravel.com/travel?mgnlPreview=false&mgnlChannel=desktop
routeTemplate: '/{language}{{@name}}'
http://cooltravel.com/website/travel?mgnlPreview=false&mgnlChannel=desktop
Expectation: Do not include website in url. Should be like this: http://cooltravel.com/travel?mgnlPreview=false&mgnlChannel=desktop
Hint: May be missing switch case for NAME in DefaultSpaRouter. This is example of Path case in this PR: https://git.magnolia-cms.com/projects/MODULES/repos/pages/pull-requests/486/diff#magnolia-spa-norsu-rendering/src/main/java/info/magnolia/pages/norsu/routing/DefaultSpaRouter.java |
| Comments |
| Comment by Canh Nguyen [ 07/Feb/23 ] |
|
DefaultSpaRouter supports few new properties:
|
| Comment by Canh Nguyen [ 08/Feb/23 ] |
|
mdrapela 👆 |
| Comment by Martin Drápela [ 09/Feb/23 ] |
|
canh.nguyen , will doc as part of |