[PAGES-116] Multiple instances of same dialog opening Created: 22/Aug/16  Updated: 26/Feb/19  Resolved: 31/Jan/17

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: 5.4.6, 5.5
Fix Version/s: 5.4.10, 5.5.2

Type: Bug Priority: Major
Reporter: shubha gowda Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: 0d
Time Spent: 1h
Original Estimate: Not Specified

Attachments: File MultipleDialogIssue.webm    
Issue Links:
Relates
relates to MGNLUI-4131 Prevent triggering actionbar actions ... Closed
causality
dependency
is depended upon by MGNLPN-357 Multiple instances of edit dialog ope... Closed
supersession
supersedes MGNLUI-2578 Double Clicking on an Action Should N... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Visible to:
Meenakshi Bhattacharya
Sprint: Kromeriz 79, Kromeriz 81
Story Points: 13

 Description   

When an application takes little more time to load the dialog box to edit the component of a page, some of our application editors tries to click the edit button multiple times which opens up multiple dialog box.
Is there a way to limit it to open a single dialog, even for a multiple tries to edit the same component.
Attached the recordings for your reference.
Note: When the multiple dialog box opens up and editor tries to author the top one and save it, the underlying dialog box pops out without the latest changes saved in the top dialog box of the same component, which leads confusions to the editor whether the content has been saved or not.



 Comments   
Comment by shubha gowda [ 22/Aug/16 ]

Raising a defect in MGNLUI with reference to support ticket (https://jira.magnolia-cms.com/browse/SUPPORT-6496)

Comment by Mikaël Geljić [ 22/Dec/16 ]

Should be prevented in similar fashion to what Vaadin has for buttons: Button#setDisableOnClick.
—btw, I could produce it from both the action bar and from a component edit bar, so we might need a clone in PAGES project. Faking some latency might also help reproducing.

Comment by Roman Kovařík [ 16/Jan/17 ]

For release notes:

  • The edit element button on the page editors bars is now disabled on click to prevent confusion when multiple instances of the same dialogs are opened.
  • If you are using a custom implementation for /modules/pages/apps/pages/subApps/detail/actions/editElement, be aware that the content change event has to be sent also on on the cancel action of the dialog
Generated at Mon Feb 12 06:15:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.