[PAGES-1287] Add support for $type to enableAllWithRenderType Created: 08/Aug/23 Updated: 13/Sep/23 |
|
| Status: | Open |
| Project: | Magnolia pages module |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Normal |
| Reporter: | Bartosz Staryga | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: | ||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Epic Link: | AuthorX improvements | |||||||||||||||||||||||||
| Team: |
| Description |
|
The `enableAllWithRenderType` expects the `renderType` prop to be present in page definition. We can now omit using `renderType` by using the `$type`, which is very useful for headless projects cause it also allows us to omit the `class` prop. `$type` does set implicitly the `renderType`, but the `enableAllWithRenderType` rule does not support it. Could we improve the `enableAllWithRenderType` feature to take into account the what `$type` sets? |