[PAGES-1315] JcrPagesDeliveryEndpoint does not consider the site template/prototype Created: 06/Sep/23  Updated: 19/Sep/23  Resolved: 14/Sep/23

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.31

Type: Bug Priority: Neutral
Reporter: Dai Ha Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 2d 5h Time Spent: 1d 1h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Cloners
clones PAGES-1308 AreaNodeHelper class getTemplateDefin... Closed
is cloned by PAGES-1346 PORT the fix of JcrPagesDeliveryEndpo... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
PAGES-1337 Implement Sub-task Closed Oanh Thai Hoang  
PAGES-1338 Review Sub-task Completed Dai Ha  
PAGES-1339 piQA Sub-task Completed Javier Benito  
PAGES-1340 QA Sub-task Completed Dai Ha  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: Support
Sprint: DevX 46
Story Points: 3
Team: DeveloperX
Work Started:
Approved:
Yes

 Description   

info.magnolia.rendering.spa.renderer.AreaNodeHelper#getTemplateDefinition  supposed to get the template definition for a node.

Basically that works, but it does not consider the site template/prototype.

So if an area is defined in <Light Module>/template/pages/page.yaml, it is picked up correctly.

But if the area is defined in <Site>/templates/prototype/areas/, it is not picked up.



 Comments   
Comment by Jochen Klein [ 12/Sep/23 ]

Please check: There is duplicate code with the same problem in: 

info.magnolia.rendering.spa.rest.v2.inheritance.TemplateDefinitionHelper.getAssignedTemplateDefinition(Node)
Comment by Oanh Thai Hoang [ 13/Sep/23 ]

Hi jaklein , thanks for your info. We have proposed PR and under piQA process

 

Generated at Mon Feb 12 06:27:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.