[PAGES-133] Update the TemplateTypeRestrictionDropConstraint to make it can reuse in the move dialog Created: 05/May/17  Updated: 30/May/17  Resolved: 26/May/17

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: 5.5.3
Fix Version/s: 5.5.5

Type: Improvement Priority: Neutral
Reporter: Sang Ngo Huu Assignee: Sang Ngo Huu
Resolution: Fixed Votes: 0
Labels: move-dialog
Remaining Estimate: 0d
Time Spent: 3.25d
Original Estimate: 3d

Issue Links:
Relates
relates to MGNLUI-4207 Replace move-predicates back with dro... Closed
relates to MGNLSITE-79 "Move Before" and "Move After" button... Closed
causality
caused by MGNLUI-4194 Generalize code for move-availability... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Sprint: Saigon 96, Saigon 97
Story Points: 5

 Description   

The MovePredicate is marked as deprecated and replaced by DropConstraint in MGNLUI-4194, so we need to update TemplateTypeRestrictionDropConstraint to support in move dialog as well

Ideas:

  • Extends TemplateTypeRestrictionDropConstraint from JcrDropConstraint
  • Add more code for move before and move after


 Comments   
Comment by Khuong Nguyen [ 10/May/17 ]

Currently, behavior of move before, move after and move inside in move dialogs is incorrect.

Steps to reproduce:

  • Open Pages app, select "/travel/tour"
  • Choose "Move page"
  • Take a look on Move Dialog
    => Expected: Move Before, Move After and Move Inside are disabled
    => Actual: Move Before, Move After and Move Inside are enabled (although we don't select any destination. When we click on Move buttons, error will happen).
Generated at Mon Feb 12 06:15:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.