[PAGES-1401] Enable developer to control if greenbars are rendered inside or outside the template HTML Created: 02/Oct/23 Updated: 18/Dec/23 |
|
| Status: | Accepted |
| Project: | Magnolia pages module |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: | ||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | Headless Backlog | |||||||||||||||||||||||||
| Team: |
| Description |
|
Generally, editbars are added above whatever html the component renders. But when the component renders a single parent element, and that element is a div, then the editbars are rendered inside that parent div. (Update: probably this is the case not only with "div" but any block level html element.) We should likely document the current behaviour. It does seem important for developers to put the bars in one place or the other - so we could maybe add some kind of property to control this - either in the HTML of the template - or maybe a setting on the template definition."render-bars-inside" "render-bars-outside". For context also see this input where a customer does not like the bars being rendered inside:
Any change should be made carefully as we must ensure to be backwards compatible as customers may be relying on this behaviour now.
|