[PAGES-142] Inherit #isMessageKey from AbstractFieldFactory Created: 02/Aug/17 Updated: 01/Sep/17 Resolved: 30/Aug/17 |
|
| Status: | Closed |
| Project: | Magnolia pages module |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.6 |
| Type: | Task | Priority: | Minor |
| Reporter: | Mikaël Geljić | Assignee: | Oanh Thai Hoang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 6.5h | ||
| Original Estimate: | 1d | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoR: |
Empty
|
||||||||
| Sprint: | Saigon 110, Saigon 111 | ||||||||
| Story Points: | 2 | ||||||||
| Description |
|
ComponentSelectorFieldFactory and TemplateSelectorFieldFactory previously contained the same method—yet as private. This is binary-compatible but those factories need to be adjusted whenever pages depends upon UI 5.5.6+ (methods may simply be removed if similar). This method checks whether an @I18nText config property is likely to be a message key (from key-generators) or a proper translation. As definitions are proxies to the translation-service, this method is often the only choice to know if a translation exists or not. Some UI components may decide not to display the unresolved message key when such translation does not exist (like for the placeholder text in the aforementioned UI ticket, or here for template titles). |