[PAGES-20] Extensions: pass location to start() method Created: 08/May/15  Updated: 20/May/15  Resolved: 11/May/15

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: None
Fix Version/s: 5.4

Type: Improvement Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLSLOCK-32 Port soft locking module to 5.0 Closed
is depended upon by MGNLPN-211 VariantSelector: add location to star... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   
  • We already have the location when the extension is started. It's just not passed atm.
  • Allows properly instantiating the extension already during start and we can also distinguish whether a location change happened or the extension was started.


 Comments   
Comment by Philip Mundt [ 12/May/15 ]

Minor adjustment: info.magnolia.pages.app.editor.pagebar.platformselector.PlatformSelector introduces duplicate code

boolean isPreview = DetailView.ViewType.VIEW.equals(location.getViewType());

if (!isPreview) {
    resetCurrentPlatform();
}

setVisible(isPreview);
  • Introduce private method or use #onLocationUpdate(DetailLocation) instead?
Generated at Mon Feb 12 06:14:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.