Migrate app to new framework (PAGES-194)

[PAGES-203] Component node is created on opening of dialog instead of on save Created: 30/Oct/19  Updated: 19/Nov/19  Resolved: 18/Nov/19

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: 6.2
Fix Version/s: 6.2

Type: Sub-task Priority: Neutral
Reporter: Robert Šiška Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1d 3h 47m
Original Estimate: Not Specified

Template:
Date of First Response:
Sprint: UI Framework 7, UI Framework 8, UI framework 9, UI Framework 10

 Comments   
Comment by Roman Kovařík [ 14/Nov/19 ]

Encounter two other issues with create component:

  • cancel on component dialog leaves unsaved component in valueContext
    • as that could be dialog of any component, we can't have a custom cancel action to reset the value context (except wrapping action with a mutator..I don't want to go that way)
    • experimented with valueContext.intercept(), but as we want to intercept only in create page action, we again don't know when the action is finished and we should remove the intercepter (also dynamically adding/removing interceptors is probably not a good idea either)
    • observation not usable as well as cancel doesn't trigger any observation (unless triggered manually in default cancel action, same way as in the commit action...that probably doesn't make sense)
  • new component not saved when no dialog field is touched
    • if no field is touched on the component dialog, binder.hasChages() skipps the save..this calls for extracting finally the session save from CommitingBinder
Generated at Mon Feb 12 06:16:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.