[PAGES-271] Aborting page properties dialog leaves traces in workspace Created: 19/Mar/20 Updated: 23/Aug/21 Resolved: 14/May/20 |
|
| Status: | Closed |
| Project: | Magnolia pages module |
| Component/s: | None |
| Affects Version/s: | 6.2 |
| Fix Version/s: | 6.2.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Michael Duerig | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | 0d | Remaining Estimate: | 0d |
| Σ Time Spent: | 3h 31m | Time Spent: | 3h 31m |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| Sub-Tasks: |
|
||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||
| Epic Link: | Migrate apps to new UI framework | ||||||||||||||||||||||||||||||||||||||||
| Sprint: | UI Framework 21, UI Framework 22, TE 1, TE 2 | ||||||||||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||||||||||
| Description |
Steps to reproduce
Observed behaviourA new page is created however it is missing the mandatory cookie consent wording - compliance type. This can be seen by opening the pages properties dialog for the newly created page. Expected behaviourWhen cancelling the pages properties dialog on a new page, no page should be created at all. NotesThe page node is already created when clicking next on the initial add node dialog right before the page properties dialog appears. It is at this point where the "invalid" page is persisted. According to rkovarik there was a decision at some point to not keep unsaved changes in memory between request. As a consequence we need to rethink how to do validation across multiple request. |
| Comments |
| Comment by Rishab Dhar [ 15/Apr/20 ] |
|
apchelintcev Alternative solution to sharing data between actions to delay page creation until commit has been triggered on Page properties dialog by the user. There are two side-effects that need to tackled:
[^create_page.pdf] |
| Comment by Rishab Dhar [ 30/Apr/20 ] |
|
Reworks the internal workflow of page creation by wrapping newly created Pages which have a configured dialog into NewRenderableNodeWrapper. The metadata that needs to configured for newly created Page/Component is shared using RenderableNodeMetadata as DTO.
|