[PAGES-323] Missing Constructor at ConfiguredSpaRenderableDefinition Created: 05/Aug/20 Updated: 30/Apr/21 Resolved: 11/Aug/20 |
|
| Status: | Closed |
| Project: | Magnolia pages module |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.2.3 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Canh Nguyen | Assignee: | Canh Nguyen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | SPA Editor | ||||||||
| Sprint: | HL & LD 8 | ||||||||
| Story Points: | 0 | ||||||||
| Description |
|
The ConfiguredSpaRenderableDefinition is extending the Check ConfiguredSpaRenderableDefinition java class at git. The TemplateAvailability is needed to manage the template availability. The Steps to reproduce :
Workaround: Add the constructor to the ConfiguredSpaRenderableDefinition class: /** * This file Copyright (c) 2019 Magnolia International * Ltd. (http://www.magnolia-cms.com). All rights reserved. * * * This file is dual-licensed under both the Magnolia * Network Agreement and the GNU General Public License. * You may elect to use one or the other of these licenses. * * This file is distributed in the hope that it will be * useful, but AS-IS and WITHOUT ANY WARRANTY; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A * PARTICULAR PURPOSE, TITLE, or NONINFRINGEMENT. * Redistribution, except as permitted by whichever of the GPL * or MNA you select, is prohibited. * * 1. For the GPL license (GPL), you can redistribute and/or * modify this file under the terms of the GNU General * Public License, Version 3, as published by the Free Software * Foundation. You should have received a copy of the GNU * General Public License, Version 3 along with this program; * if not, write to the Free Software Foundation, Inc., 51 * Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * 2. For the Magnolia Network Agreement (MNA), this file * and the accompanying materials are made available under the * terms of the MNA which accompanies this distribution, and * is available at http://www.magnolia-cms.com/mna.html * * Any modifications to this file must keep this entire header * intact. * */ package info.magnolia.rendering.spa.renderer; import info.magnolia.rendering.template.configured.ConfiguredTemplateDefinition; import java.util.List; import lombok.Getter; import lombok.Setter; import lombok.ToString; /** * Default implmentation for {@linkplain SpaRenderableDefinition}. */ @Getter @Setter @ToString public class ConfiguredSpaRenderableDefinition extends ConfiguredTemplateDefinition implements SpaRenderableDefinition { private List<String> jsPaths; private List<String> cssPaths; @Inject public ConfiguredSpaRenderableDefinition(TemplateAvailability templateAvailability) { super(templateAvailability); } } |
| Comments |
| Comment by Joerg von Frantzius [ 28/Apr/21 ] |
|
Hi, I wonder how this supposed to be fixed, as https://git.magnolia-cms.com/projects/MODULES/repos/pages/browse/magnolia-spa-rendering/src/main/java/info/magnolia/rendering/spa/renderer/ConfiguredSpaRenderableDefinition.java still doesn't contain the required constructor, and doesn't have the equivalent Lombok annotation? |
| Comment by Joerg von Frantzius [ 28/Apr/21 ] |
|
Neither does it with tag 6.2.7: https://git.magnolia-cms.com/projects/MODULES/repos/pages/browse/magnolia-spa-rendering/src/main/java/info/magnolia/rendering/spa/renderer/ConfiguredSpaRenderableDefinition.java?at=refs%2Ftags%2Fmagnolia-pages-6.2.7 |
| Comment by Robert Šiška [ 30/Apr/21 ] |
|
I'm not sure I understand what's the issue here. ConfiguredSpaRenderableDefinition(final TemplateAvailability templateAvailability) constructor was added in 6.2.3 in 5th August 2020 and it is still there now. Following the reproduction steps: ConfiguredTemplateDefinition has no 'templateType' property, it should be just 'type'. But that shouldn't cause a missing constructor message. |