[PAGES-334] Available templates datasource reacts on value context changes and triggers expensive computation Created: 02/Sep/20  Updated: 29/Oct/21  Resolved: 10/Sep/21

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: 6.2.2
Fix Version/s: 6.2.11

Type: Bug Priority: Neutral
Reporter: Šimon Demočko Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 52m
Original Estimate: Not Specified

Issue Links:
causality
is causing PAGES-530 Available templates couldn't be filte... Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: Column filtering
Sprint: UI FW 36
Story Points: 5

 Description   

Steps to reproduce

  • create component dialog
  • create page dialog
  • template column filter

Expected results

  • the combobox is populated with options only once (as the template availability resolving might be expensive)

Actual results

  • the combobox is repopulated with any value context change

Workaround

Patch for Magnolia 6.2.9

<dependency>
  <groupId>info.magnolia.pages</groupId>
  <artifactId>magnolia-pages-app</artifactId>
  <version>6.2.8-PAGES-334</version>
</dependency>

Development notes

  • Roman mentioned here that "it shows available templates for the page in value context (or root when no selection)" This should not happen for list view.
  • Same issue is with tree view, but we might be soon removing tree filtering altogether anyway. In case we would want to keep filtering in tree view, read this too, otherwise irrelevant: It's not desirable even in Tree view, b/c from user point of view, I am adding a filter on top of the grid and I would expect to be able to filter out everything in the grid in this way. The fact that there is a value context amended by current selection and that it affects filters is a very technical detail a user has no knowledge of.


 Comments   
Comment by Roman Kovařík [ 13/Sep/21 ]

For release notes:
Template selector (template column filter, create page/component dialog) is populated only once to avoid triggering template availability repeatedly.

Generated at Mon Feb 12 06:17:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.