[PAGES-344] Cannot rename a page when pressing on Enter button Created: 16/Sep/20  Updated: 16/Sep/20  Resolved: 16/Sep/20

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Thuy To Assignee: Unassigned
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by ANALYTICS-219 Cannot create a new dashboard when pr... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Step to reproduce:

+ Rename a page

+ Input a valid name

+ Press on Tab button, after that continue to press on Enter button of keyboard

Actual result: The dialog is closed but the page isn't renamed.



 Comments   
Comment by Thuy To [ 16/Sep/20 ]

The issue links to https://jira.magnolia-cms.com/browse/ANALYTICS-219

Comment by Šimon Demočko [ 16/Sep/20 ]

So the comment's not lost, copying from Slack

It appears the reprosteps by pressing tab focus the cancel button. Upon pressing Enter the focused button (cancel) is pressed. Enter is a shortcut as long as you're not in a field accepting enters as new lines or on buttons, in which case enter triggers the focused button. 

If this seems reasonable, feel free to close as invalid. If we want to enter to always trigger the shortcut action, we'd need other means to trigger focused buttons - e.g. Spacebar. This would have to be further discussed with UX though, since it's not the conventional pattern we would use at the moment over Magnolia.

Comment by Thuy To [ 16/Sep/20 ]

I checked. It's not an issue. Thanks sdemocko :bow:

Generated at Mon Feb 12 06:18:01 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.