[PAGES-345] Nodetype is hardcoded as mgnl:page inside Pages actions Created: 16/Sep/20 Updated: 18/Oct/22 Resolved: 05/Aug/22 |
|
| Status: | Closed |
| Project: | Magnolia pages module |
| Component/s: | Pages app |
| Affects Version/s: | 6.2.3 |
| Fix Version/s: | 6.3.0, 6.2.21 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Chris Jennings | Assignee: | Robert Šiška |
| Resolution: | Fixed | Votes: | 2 |
| Labels: | maintenance | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 1.25d | Time Spent: | 1d |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
|||||||||||||||||||||||||
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Patch included: |
Yes
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Release notes required: |
Yes
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | Multiple PageEditor Apps | |||||||||||||||||||||||||
| Sprint: | DevX 15, DevX 16 | |||||||||||||||||||||||||
| Story Points: | 3 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Description |
|
When creating a new page using CreatePageActionDefinition/CreatePageAction, the node type is hardcoded. Clients using the framework of the Pages app to create pages may wish to use other nodetypes to identify where the app is being used to manage pooled content. eg. reusable banners or when they wish to serve content managed with the WYSIWYG functionality of the Pages app via a REST API. I would like to see the nodetype configured in the action definition and the class names changed to reflect their new open-ness. |
| Comments |
| Comment by Chris Jennings [ 16/Sep/20 ] |
|
PR exists here: https://git.magnolia-cms.com/projects/MODULES/repos/pages/pull-requests/231/ |
| Comment by Chris Jennings [ 01/Oct/20 ] |
|
Hi, slutz ie. Click create, be presented with a drop-down, be presented with an associated dialog for the selected type. Currently I can create an untitled node and then open it for editing but it is created with all blank fields. I can still reference it, publish it, and retrieve it. |
| Comment by Christopher Zimmermann [ 01/Oct/20 ] |
|
AFAIK 6.2 already takes us closer to being able to have additional "Pages" apps (typically to manage page fragments, like a banner) as many of our customers do, but with much less technical fuss/custom java extensions. I can't say anything about the PR, but the desire to be able to specify the node type (and not use "mgnl:page") is very much in line with Magnolia best practice. So it appears to me that this moves us closer towards having multiple "pages" apps easily, sooner, without the bigger changes that will eventually come with Creative Fragments initiative. |
| Comment by Oanh Thai Hoang [ 05/Aug/22 ] |
|
QA done from me. |