[PAGES-38] TemplateSelectorFieldFactory may return a blank label Created: 18/Sep/15  Updated: 15/Apr/16  Resolved: 18/Sep/15

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: None
Fix Version/s: 5.4.2

Type: Bug Priority: Neutral
Reporter: Federico Grilli Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.25d
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLUI-3599 TemplateSelectorFieldFactory may retu... Closed
dependency
is depended upon by MGNLUI-3521 SelectFieldOptionDefinition compariso... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Basel 11
Story Points: 1

 Description   

Make sure TemplateSelectorFieldFactory never returns a blank label. Fall back to name or id (never null).



 Comments   
Comment by Mikaël Geljić [ 23/Sep/15 ]

I'm considering a minor amendment while doing QA: I'm not sure actually whether "name" is much relevant here, it's just a (too) simple string.
So if a user is looking at an untitled template in the list, she might need to dig to see where this name come from—whereas if we fallback directly on the "id", then she has a better chance to locate the untitled template. What do you think?

Comment by Federico Grilli [ 23/Sep/15 ]

Me gusta!

Comment by Mikaël Geljić [ 23/Sep/15 ]

Mucho mejor

Generated at Mon Feb 12 06:15:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.