[PAGES-387] Components Are Still Editable When Editable Property Is False Created: 29/Jan/21  Updated: 22/Nov/21  Resolved: 22/Nov/21

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Julian Nodarse Assignee: Lam Nguyen Bao
Resolution: Obsolete Votes: 1
Labels: headless-team-support, maintenance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File when_editable_false.PNG     PNG File when_editable_true.PNG    
Issue Links:
Problem/Incident
Relates
relates to PAGES-456 Component restrictions are not working Closed
relation
is related to PAGES-456 Component restrictions are not working Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: SPA Editor
Sprint: HL & LD 40, Pages Maintenance 1
Story Points: 2

 Description   

Verify:

Steps to reproduce

  • You can see this in the demo by editing:

travel-demo/templates/pages/home.yaml

  • Set the footer to editable : false (it might be false already)
  • Check the travel/tour-type page 
  • Scroll down to the footer, click on "About Magnolia Travels"

Expected results

You cannot edit the footer even if you click on the component

Actual results

You can see the edit actions on the actionbar and making changes will persist throughout other templates.

Development notes

I tried adding editable: false in other definitions such as /travel-demo/templates/pages/prototype.yaml just in case and it just seems like the green boxes around the component do not get highlighted, but the action bar on the right still shows actions. You can then edit the component and the change will be seen on other pages using the same footer.

I attached 2 screenshots, the first is showing how it looks when editable is true and the second when it is false. Notice that both still show the actions and are editable but the one enabled has the green boxes instead.



 Comments   
Comment by Leah Staniorski [ 21/May/21 ]

This is only an issue with the new UI 6 Pages app. If you go to the appLauncherLayout and delete the "pages" property (old UI 5 pages app) from the hiddenApps, log out and log back in, and look in the old Pages app you will not see the "Edit component" action highlighted. So this issue was introduced with the new Pages app. May be something with action availability? 

Generated at Mon Feb 12 06:18:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.