[PAGES-630] "Add component" before/after selected component is broken in 6.2.19 Created: 02/Jun/22  Updated: 06/Jul/22  Resolved: 09/Jun/22

Status: Closed
Project: Magnolia pages module
Component/s: Pages app
Affects Version/s: 6.2.18
Fix Version/s: 6.3.0, 6.2.19

Type: Bug Priority: Critical
Reporter: Maik Jablonski Assignee: Jesus Alonso
Resolution: Fixed Votes: 0
Labels: authx
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 40m Time Spent: 40m
Σ Original Estimate: Not Specified Original Estimate: Not Specified
Environment:

https://demo.magnolia-cms.com/


Issue Links:
causality
caused by MAGNOLIA-8368 Class should take precedence over $type Closed
relation
is related to PAGES-671 "Add component" before/after selected... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
PAGES-639 Coding Sub-task Completed Jesus Alonso  
PAGES-640 piQA Sub-task Completed Yen Lac Tue  
PAGES-641 QA Sub-task Closed Thuy To  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
[ ]* Integration test to prevent regression (FakeMagnoliaUI should be enough)
Release notes required:
Yes
Date of First Response:
Epic Link: Add and paste components anywhere
Sprint: AuthX 11
Story Points: 0.5
T-Shirt Size: Small
Team: AuthorX

 Description   
  • Login to https://demo.magnolia-cms.com/
  • Go to Pages -> /sportstation/about
  • Select first component (Jumbotron - Header for a page)
  • Click "Add component" in sidebar and select a componet
  • Now an error occurs (Action execution failed for action: commit)
  • This behaviour affects all areas and components.


 Comments   
Comment by Roman Kovařík [ 03/Jun/22 ]

Hi mjablonski 

Thanks for reporting the issue.
You can fix the issue by editing/decorating createNewComponentWithSelectedComponent.yaml:

-   $type: createNewComponentWithSelectedComponentAction
+   class: info.magnolia.pages.app.detail.action.CreateNewComponentWithSelectedComponentAction

Personally, I'd use aliases only for commonly used definitions in most of the apps/dialogs, not for app/dialog specific definitions as nobody can remember so many custom aliases anyway .

Hope that helps.

Roman

Comment by Maik Jablonski [ 10/Jun/22 ]

Hi Roman,

I've tried your suggestion, but it doesn't work locally or on the magnolia demo site.

If I try to add a component, only the "Cancel"-Button is displayed, but no "Add"-Button" in the component choose dialog.

Maybe you can re-check.

Cheers, Maik

Generated at Mon Feb 12 06:20:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.