[PAGES-656] Creating/Editing/Removing a component variant doesn't modify the page status Created: 21/Jun/22  Updated: 18/Oct/22  Resolved: 05/Sep/22

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Roberto Gaona Assignee: Jesus Alonso
Resolution: Won't Fix Votes: 0
Labels: personalization
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLPN-704 DOC: Describe how editing a Component... Closed
causality
relation
is related to PUBLISHING-87 Publish a page does not include variants Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: AuthorX Support
Sprint: AuthX 17
Team: AuthorX

 Description   

Creating or modifying a component variant for a component which already has other variant assigned, makes it so the page status isn't altered (publication of the page still publishes the new changes to the variant).

Reproducible steps:

  • Add an initial variant to a page and publish. Verify status is green
  • Add/Modify/Remove a second variant (Removing a solo variant, does modify the page)

Expected outcome:
The page is put into a modified state for each component action

Actual outcome:
The page is only put into a modified state if you create an initial variant, or delete the only variant.



 Comments   
Comment by Jesus Alonso [ 05/Sep/22 ]

This comment has been copied from PUBLISHING-87:

We don't want to fix it. Only page and related content(areas, components...) should be published when "publish" action is triggered. This was decided when p13n module was introduced. If we change default behaviour also to publish page variants than we lose flexibility to publish only page itself.
Example: Marketing team prepares page variants for promotion in US, but they are not ready yet and meantime we need change in original page new content/fix typo/... if we change default behaviour for publish action then also the unfinished page variants are published.

The default behaviour for publish can be easily changed by simple modification of publish command:
The default publish command used by pages app is "workflow-activation" which uses the "default-personalizationActivation" command. So we need to add "mgnl:variants" and "mgnl:variant" nodeTypes to the command.
/modules/personalization-core/commands/default/personalizationActivation@itemTypes == "mgnl:contentNode,mgnl:componentVariants,mgnl:variants,mgnl:variant"

Generated at Mon Feb 12 06:21:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.