[PAGES-73] Add link extension in page bar editor to open the page in a browser tab Created: 12/Apr/14  Updated: 09/Mar/21  Resolved: 09/Sep/16

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: 5.4.5
Fix Version/s: 5.4.8, 5.5

Type: New Feature Priority: Major
Reporter: Tom Wespi Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 3
Labels: page-editor, ux
Remaining Estimate: 0d
Time Spent: 6d 5h 10m
Original Estimate: 2d

Attachments: PNG File issue_step1.png     PNG File issue_step2.png     PNG File issue_step3.png    
Issue Links:
causality
is causing PAGES-90 Open-in-tab button does not open corr... Closed
dependency
depends upon MGNLUI-3857 Provide css for page preview link in ... Closed
duplicate
duplicates MGNLUI-2693 add option to to preview page in new ... Closed
relation
is related to PAGES-401 Full-screen view for the page editor ... Open
is related to PAGES-398 Offer a full-screen preview in the vi... Closed
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Epic Link: AX: improve page editor
Sprint: Saigon 58
Story Points: 3

 Description   

This issue asks for a new action to be added in the page editor and page editor preview, which opens the existing page in a new browser tab or window (depending on the browser's settings). Some use cases ask you to verify or just see page parameters. Sometimes it's desirable to simply see the page _without anything that Magnolia adds to or surrounding it*. This is also useful to see the actual url of the page. This can be useful for testing on a different device.

In the page editor, the action should be added directly after the exising "preview page" action.
In the page bar editor, one button is added on the very end of the right corner, after the language dropdown.

As this must work in Safari, this ticket must be resolved first: DEV-78

http://demoauthor.magnolia-cms.com/.magnolia/admincentral;#app:pages:detail;/demo-project/about/history:edit

http://demoauthor.magnolia-cms.com/demo-project/about/history



 Comments   
Comment by Richard Unger [ 02/May/14 ]

+1 for this feature.

If I understood tom correctly, this would be a feature in the pages app.

I would call the action "Preview in new Window" or "Preview (new Window)"

I think this would be a quick win.

Comment by Richard Unger [ 02/May/14 ]

In theory this action could be available both in the browser and details subapps of the pages app.

Comment by Tom Wespi [ 02/May/14 ]

Yes Richard, this would be a feature in the Pages App.
"Preview in new Window" would be a good naming for this action.

Comment by Christopher Zimmermann [ 17/Dec/15 ]

What about "Preview in browser", or "Open in browser" as a name?
I actually think "Preview in new window" is fine - but I could imagine someone thinking that it just opens the whole page editor in a new window.

Comment by Christopher Zimmermann [ 17/Dec/15 ]

The current description specs "new action to be added in the page editor preview", I feel strongly that this common usecase should also be available on the page editor (not just the page preview). The default action from the page tree opens the page editor - so many people will go there by default.
Certainly as a developer - that is where I live, I dont want to have to go to the preview first - and then access the action there - and then go back to the editor.

As to whether the action should be available in the page tree - im on the fence. I see the benefit - but also dont want to add too many actions.

Comment by Sang Ngo Huu [ 28/Dec/15 ]

mgeljic I added bootstrap for default page app. When personalization module is installed, this module will create new view as visitor page, should I create new ticket to add new action to personalization module?

Comment by Mikaël Geljić [ 28/Dec/15 ]

sang.ngo I don't think it's necessary, we have the preview-as-visitor app for that; full-screen page-editor will help as well.

Comment by Christopher Zimmermann [ 06/Jan/16 ]

Scope of ticket has been changed. The new action should also be available in the page editor (not just the preview). Description of ticket has been updated.

Comment by Mikaël Geljić [ 16/Aug/16 ]

The approach for such facility in the "page bar" look compelling so far. Just a tiny question for you weder:

Should the icon be external-webpage (180) or open-new-window (082). What would be the intent for using one or the other nowadays?

Comment by Oanh Thai Hoang [ 24/Aug/16 ]

documentation update, see javadoc of info.magnolia.pages.app.editor.pagebar.nativepagepreviewlink.NativePagePreviewLinkExtensionDefinition#setTarget:

Defines the target (_blank, _self, _parent, _top, framename) to specifies where to open the link.

Comment by Hieu Nguyen Duc [ 25/Aug/16 ]

After QA, I've found an issue. It's probably not related to this ticket but it causes a weird behavior.

   + Go to "Destinations" / "Central & South America"
         

   + Click Page Link icon, it shows
         
 

   => Expected: It shows "Central & South America" page
http://localhost:8080/magnoliaAuthor/travel/destination~southAmerica~.html

   => Actual: It shows a strange page.
http://localhost:8080/magnoliaAuthor/travel/destination.html
 

There's also one more similar issue.

   + Go to "Destinations" / "Central & South America"

   + Click Preview Page on action bar, it shows
         
 

   => Expected: Preview "Central & South America" page

   => Actual: Preview strange page
 

Comment by Mikaël Geljić [ 25/Aug/16 ]

Yes these are dynamic pages (or however we call those with the tilde selector); as you can see, you're always editing/previewing the same page/node in the website tree (there's just one destinations node too). I would argue the dynamic part is just an arbitrary tour or tourCategory; it's not that relevant when editors preview those pages (vs. actual page areas/comps)—these are not edited in the pages app but in their own content-apps.

Currently, page-editor doesn't preserve dynamic parameters (same when you perform a search), not sure what the intricacies were back then, but we might do something there, eventually.
Anyway you said it, it's not related to this ticket. Opening in new tab just follows that same behavior. All good from my side.

—re: "strange page", yeah that's unfortunate that the destinations page picks up a tour-type as default (the "active" one); my guess is it picks the first eligible node in that workspace. It should probably look at the destinations subpath by default, or expect a more specific node-type for destinations vs. tour types. That's a problem of the demo.

Comment by Philip Mundt [ 09/Sep/16 ]

Change brought in via QA commit QA Get correct definition corresponding with extension name
(See https://git.magnolia-cms.com/projects/MODULES/repos/pages/commits/30b0378940f77d21b447950a04e1ddbf801cbb22) breaks (binary) compatibility, namely google-analytics visualization's page extension doesn't work anymore. This cannot be done in a minor release, therefore the commit was reverted on magnolia-pages-5.4.x branch.

Comment by Milan Divilek [ 09/Sep/16 ]

After discussion with pmundt and rkovarik we decided just to fix backward compatibility.

Generated at Mon Feb 12 06:15:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.