[PAGES-75] Status indicator is always red for empty optional areas Created: 22/Apr/16  Updated: 15/Jun/16  Resolved: 14/Jun/16

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: 5.4.4, 5.4.6
Fix Version/s: 5.4.7

Type: Improvement Priority: Neutral
Reporter: Diana Racho Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: 0d
Time Spent: 4d 2.5h
Original Estimate: 3d

Attachments: PNG File screenshot-1.png     PNG File status_indicator.png    
Issue Links:
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Sprint: Saigon 48
Story Points: 5

 Description   

Empty optional areas show always a red status indicator although the page is activated.



 Comments   
Comment by Oanh Thai Hoang [ 31/May/16 ]

Root cause: The optional area node does not create automatically a node on page rendering for it's purpose. Please refer to link here to see it's specification. That's is the reason the areaNode is always null while deleting area or empty optional area even when the page was published because it does not exist in JCR.

Couldn't find any simple approach to resolve activation status by area' parent or area' child from now.

Comment by Mikaël Geljić [ 31/May/16 ]

So the place-holder should not display any activation status when the optional area is not present.
Re: deletion, I guess we delete the area node right away, so the page should get the modified status then.

Does this make sense, or did I omit any use case?

Comment by Oanh Thai Hoang [ 31/May/16 ]

Thanks, mgeljic.

There are 3 cases that we should consider:

  • Case 1: published page with empty optional area
  • Expectation: green indicator
  • Actual: red indicator
  • Case 2: delete optional area in published page
  • Expectation: yellow indicator
  • Actual: red indicator
  • Case 3: add area and add component inside empty optional area of published page
  • Expectation: yellow indicator
  • Actual: red indicator

--> Case 2 and case 3: it's ok to left indicator in optional area. Every case the indicator of page is still correct. But I'm not sure for case 3

Comment by Mikaël Geljić [ 31/May/16 ]

Case 1: published page with empty optional area
Expectation: green indicator
Actual: red indicator

Empty areas are fine on my side, considering a published page:

  • Area placeholder has unpublished status (bug)
  • Add the area => unpublished status (correct)
  • Publish the page => area has no-indicator (correct, not red)

Case 2: delete optional area in published page
Expectation: yellow indicator
Actual: red indicator

It should be no-indicator; the page gets the modified status. This is the same when you delete a component: only area and page nodes become modified.
Think about the remaining area bar as a placeholder; it doesn't represent the deleted area anymore.

Case 3 is the same as case 1: after the page is published once, with the area present, then adding/moving/removing components makes it modified (correct).

Side notes:

  1. Green indicator == no indicator
  2. I tested that on templating-samples (stage area is optional). When deleting the optional area, page-editor status at the bottom also becomes "unpublished" (bug)
  3. I was wondering what happens when an area is both optional and has createAreaNode set to false; then the page-editor doesn't let you delete the area, which is good. Nothing to change here.
Generated at Mon Feb 12 06:15:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.