[PAGES-843] Annotations endpoint should not fail if a template does not exist Created: 07/Sep/22  Updated: 20/Oct/22  Resolved: 05/Oct/22

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: 6.2.20
Fix Version/s: 6.3.0, 6.2.23

Type: Bug Priority: Critical
Reporter: Christopher Zimmermann Assignee: Phong Le Quoc
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 12d 1.5h Time Spent: 11d 6.5h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
relation
is related to PAGES-860 Annotations endpoint should return mi... Accepted
is related to MGNLFE-333 Should not render close comment tag Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
PAGES-844 Implementation Sub-task Completed Phong Le Quoc  
PAGES-845 Review Sub-task Completed Robert Šiška  
PAGES-846 Pre-Integration QA Sub-task Completed Robert Šiška  
PAGES-847 QA Sub-task Completed Oanh Thai Hoang  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Epic Link: SaaS TPR - SPA
Sprint: DevX 20
Story Points: 5
T-Shirt Size: Small
Team: DeveloperX

 Description   

Currently if a templaate referenced by the current page. is not found, then the templateAnnotaations endpoint will return a 404. Internally it errors out.

  1. In this case, a message should be written to the log.
  2. The annotaations endpoint should return a correct response with all of the components that have existing templates, so that the page can still render 
    1. For the component with no templaate - it could still return a node, but with some indicator that template xyz was not found. Then the frontend can render something if desired, but at very least developer can trace down the issue.

See research from Jaroslav:

https://magnolia-cms.slack.com/archives/CDGDQ4Y4E/p1661174000309829?thread_ts=1660914596.260419&cid=CDGDQ4Y4E

 


Generated at Mon Feb 12 06:22:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.