[PAGES-854] On page creation the prototype concept isn't working for the dialogs Created: 29/Sep/22  Updated: 07/Apr/23  Resolved: 14/Mar/23

Status: Closed
Project: Magnolia pages module
Component/s: Pages app
Affects Version/s: 6.3, 6.2.22, 6.2.24
Fix Version/s: 6.3.0, 6.2.26

Type: Bug Priority: Neutral
Reporter: Viet Nguyen Assignee: Thuy To
Resolution: Fixed Votes: 2
Labels: None
Remaining Estimate: 0d
Time Spent: 6d 50m
Original Estimate: Not Specified

Issue Links:
Problem/Incident
causes PAGES-1123 Page template without dialog throws e... Closed
Relates
relates to PAGES-932 siteSpa with prototype does not pick ... Open
relates to PAGES-933 Edit page properties action should be... Closed
causality
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: AuthorX Support
Story Points: 3
Team: AuthorX
Work Started:

 Description   

Steps to reproduce

  1. Create a new Travel Standard Page (just for verification)
    1. after clicking next the page dialog opens where you can enter all the information
  2. Remove the dialog on the standard template, so that it gets the dialog from the prototype (https://demo.magnolia-cms.com/.magnolia/admincentral#app:resources:edit;/travel-demo/templates/pages/standard.yaml:edit), dialog to remove:
    dialog: mtk2:pages/basic
  1. Create again a new Travel Standard Page
    1. The page is directly created without the dialog in
      1. 1.a. In this case the dialog is not getting merged from the prototype. This is the bug or missing implementation from Magnolia side we are facing.
  2. When you open the newly created page and click Edit page properties the inherited dialog from the prototype is showing up again follow the prototype definition.

Summary: On page creation the prototype concept isn't working for the dialogs.

.. Logs, screenshots, gifs...

Expected results

  • Prototype dialog gets working

.. Justify non-trivial expectations with a link to a doc or a relevant discussion.

Actual results

  • It is not working

Workaround

  • Open the created page, click on "edit page properties" to re-open the configured dialog from its prototype template.

Development notes

  • No error, no warning, no guideline open up on UI or print out in log.
  • Template prototype concept defines in this link
  • Affects 6.3 and Norsu variant too


 Comments   
Comment by Thuy To [ 17/Nov/22 ]

Discovery: Currently It's quite complex and hard to get dialog from the prototype template in client side in case of creating page action. Maybe try to find the solution in server side.

Comment by Thuy To [ 23/Nov/22 ]

Solution: try to get the dialog of prototype template from site functions  "info.magnolia.module.site.functions.SiteFunctions;" in case of creating pages.

https://git.magnolia-cms.com/projects/ENTERPRISE/repos/content-translation-support/pull-requests/51/diff#magnolia-content-tra[…]ateFinder.java?t=140

Another solution: try to debug and find how it’s constructed on client side or look into template annotation  (SPA)

Generated at Mon Feb 12 06:22:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.