[PAGES-89] Consolidate display of edit-bars for inherited elements Created: 29/Aug/16  Updated: 23/Aug/22

Status: Open
Project: Magnolia pages module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Espen Jervidalo Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-5439 CLONE - Sub components of inherited c... Closed
caused by PAGES-62 Disable duplicate action in 'single' ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Team: AuthorX

 Description   

The display of inherited areas and components have changed due to various unrelated changes in the page-editor.
IIRC inherited areas and components were always shown in the page-structure but annotated with 'inherited' on edit-bars and their actions were disabled.
Looking at the code this changed in MAGNOLIA-5439: Now all of a sudden inherited areas are wiped from the structure, but leaving the components in, which causes several side-effects, e.g. components associated with the parent-page instead of an area and different display for inherited areas vs inherited components.
This ended up crashing when PAGES-62 was introduced and blindly casting the parent of all components to MgnlArea. This was patched in a QA commit, which now consistently removes all inherited elements, but breaking the initial idea of still displaying those.

Some more notes:

  • the 'inherited' annotation was former criticized for not being i18nable.. so maybe rather have some sort of icon for display.
  • Do we actually need to display the inherited ones? adding more noise to the page.

Generated at Mon Feb 12 06:15:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.