[PAGES-930] NorsuDocs: Update definitions for SPA pages Created: 14/Nov/22  Updated: 11/Jan/23  Resolved: 04/Jan/23

Status: Closed
Project: Magnolia pages module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Adrian Brooks Assignee: Adrian Brooks
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File image-2022-12-28-14-22-19-717.png     PNG File image-2022-12-28-14-26-04-893.png    
Issue Links:
dependency
depends upon PAGES-934 Streamline the spa page definition Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: NorsuDocs
Sprint: AuthX 24 Xmas
Story Points: 0.5
Team: AuthorX
Work Started:

 Description   

The norsu changes have caused changes to the definitions for SPA pages.

However, the Pages app for JCR and Norsu differ only in an endpoint definition, see this thread in slack (PAGES delivery implementation):
"Yes it uses the pages domain classes, and there is also a response adapter that converts the norsu format into the old (jcr) output. So the only change here should be in the endpoint defintion: from JcrDeliveryEndpointDefinition to NorsuDeliveryEndpointDefinition"

Configuration notes in this thread:
"FYI there is a pmam.yaml definition that points to a different react app (baseUrl: https://picton-mahoney-rfp.vercel.app). I will update it to baseUrl: to http://localhost:3001 (not sure if we should bother with it)
I removed the trailing / from the baseUrl, hoping that we won’t get the double slashes in the PageEditor
I also updated the rest endpoints to format the delivery response to the old (jcr) format"

For the docu, class + mapping (this post):

class: info.magnolia.rest.delivery.norsu.NorsuDeliveryEndpointDefinition
nodeTypeMappings:
  'mgnl:page': info.magnolia.pages.rest.norsu.PageNodeTypeResolver


 Comments   
Comment by Adrian Brooks [ 04/Jan/23 ]

Checked with thuy.to, Thuy confirmed the first part of Andrei's comment:

pages template definitions:
class: info.magnolia.rendering.norsu.renderer.SpaRenderableDefinition
instead of `class: info.magnolia.rendering.spa.renderer.SpaRenderableDefinition`
(this change should not be needed once the https://jira.magnolia-cms.com/browse/PAGES-934 is integrated)

So, closing this ticket - no more documentation needed at this point.

Generated at Mon Feb 12 06:23:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.