[PSWDMNGR-12] Split Password manager module into core and app sub modules Created: 10/Aug/18  Updated: 15/Jul/22  Resolved: 23/Jun/22

Status: Closed
Project: Password Manager
Component/s: None
Affects Version/s: 1.2
Fix Version/s: 1.3.0

Type: Story Priority: Neutral
Reporter: Viet Nguyen Assignee: Thai Chi Minh
Resolution: Fixed Votes: 0
Labels: coresplit, maintenance
Σ Remaining Estimate: 0d Remaining Estimate: 0d
Σ Time Spent: 4d 7.5h Time Spent: 4d 7.5h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLMAIL-67 Split out app functionalities into a ... Open
Sub-Tasks:
Key
Summary
Type
Status
Assignee
PSWDMNGR-28 Implementation Technical task Completed Thai Chi Minh  
PSWDMNGR-29 Review Technical task Completed Evzen Fochr  
PSWDMNGR-30 PiQA Technical task Completed Evzen Fochr  
PSWDMNGR-31 QA Technical task Completed  
PSWDMNGR-32 Remove app from saas webapp Technical task Completed Thai Chi Minh  
PSWDMNGR-34 Update rest-client to 3.0-SNAPSHOT an... Technical task Completed Evzen Fochr  
PSWDMNGR-35 Update mail module to new major versi... Technical task Completed Evzen Fochr  
PSWDMNGR-36 Update text-recognition and image-cla... Technical task Completed Evzen Fochr  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Sprint: AdminX 12
Story Points: 5
Team: AdminX

 Description   

Currently Password manager module depends on both core module and Vaadin UI modules. As we want to develop a decouple UI framework, we'll need to split this module into core service module and app functionalities support.
Module split into 2 sub-modules

      <dependency>
        <groupId>info.magnolia.passwordmanager</groupId>
        <artifactId>magnolia-module-password-manager-core</artifactId>
        <version>1.2.1</version>
      </dependency>
      <dependency>
        <groupId>info.magnolia.passwordmanager</groupId>
        <artifactId>magnolia-module-password-manager-app</artifactId>
        <version>1.2.1</version>
      </dependency>

Parent module

  <groupId>info.magnolia.passwordmanager</groupId>
  <artifactId>magnolia-module-password-manager-parent</artifactId>
  <version>1.2.1</version>

TODO:

use core only in aws foundation and external dam projects. Both master and feature/cloud branches



 Comments   
Comment by Viet Nguyen [ 10/Aug/18 ]

Since Mail module depends on Password service from this module, we can't split Mail module into core service module without splitting Password manager module.

Comment by Michael Mühlebach [ 20/Aug/18 ]

Just a question out of curiosity: Why do we split it and what are the next steps? Is the split purely to have better organized code or do we wanna move one of the submodules eventually?

Comment by Evzen Fochr [ 17/May/22 ]

Example of relocation submodule https://git.magnolia-cms.com/projects/MODULES/repos/cache/browse?at=refs%2Fheads%2Frelease%2F5.6

Generated at Mon Feb 12 10:26:01 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.