[PSWDMNGR-14] PasswordRegistry is not included as a component in the module descriptor Created: 28/Sep/18  Updated: 12/Mar/19  Resolved: 12/Mar/19

Status: Closed
Project: Password Manager
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Jonathan Ayala Assignee: AntonĂ­n Juran
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
dependency
is depended upon by MGNLSSO-3 Migrate secrets to the password manager Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Support

 Description   

PasswordRegistry class is not declared as a component in the module descriptor and therefore it can not be injected in certain cases like in subapp instantiation.

Steps to reproduce in HelloWorld app

  1. Add maven dependency to Password-manager module
  2. Add PasswordRegistry parameter to the constructor:
    public HelloWorldMainSubApp(final SubAppContext subAppContext, HelloWorldMainSubAppView view, LocationController locationController, PasswordRegistry passwordRegistry) 
  3. Deploy and access hello world app you will get:
    info.magnolia.objectfactory.MgnlInstantiationException: Unable to resolve parameters for constructor public info.magnolia.training.developer.admincentral.vaadin.apps.helloworld.HelloWorldMainSubApp(info.magnolia.ui.api.app.SubAppContext,info.magnolia.training.developer.admincentral.vaadin.apps.helloworld.HelloWorldMainSubAppView,info.magnolia.ui.api.location.LocationController,info.magnolia.keystore.registry.PasswordRegistry). Unresolved parameter(s) are: 4th parameter which is of type info.magnolia.keystore.registry.PasswordRegistry

This is not happening in every case PasswordRegistry is injected, for instance it is successfully injected in info.magnolia.ai.image.amazon.AmazonImageRecogniser.

PSWDMNGR-13 should be taken into account in terms of security



 Comments   
Comment by AntonĂ­n Juran [ 12/Mar/19 ]

Fixed by PSWDMNGR-13

Generated at Mon Feb 12 10:26:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.