[PUBLISHING-150] Unpublishing should include modified children of the unpublished node Created: 26/Jul/22 Updated: 22/Feb/23 Resolved: 18/Nov/22 |
|
| Status: | Closed |
| Project: | Publishing |
| Component/s: | None |
| Affects Version/s: | 1.3.4 |
| Fix Version/s: | 1.4.0, 1.3.6 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Richard Gange | Assignee: | Antonín Juran |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
|||||||||||||||||||||||||
| Release notes required: |
Yes
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | Nucleus Quality Maintenance | |||||||||||||||||||||||||
| Sprint: | Nucleus 23 | |||||||||||||||||||||||||
| Story Points: | 3 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Description |
|
When moving published items between trees there can sometimes be inconsistent states. Reproduce
| - travel
| - about
| - tour
| - sportstation
| - about
| - tour
| - test
Move the test page under the travel page.
| - travel
| - about
| - tour
| - test
| - sportstation
| - about
| - tour
The test page should now be in a modified (yellow) state. However on the public instance the page remains under the sportstation tree. If the user then unpublishes the entire travel tree (unpublish incl subnodes) the test page will remain under the sportstation tree on the public instance.
| - sportstation
| - about
| - tour
| - test
Expected Actual Notes |
| Comments |
| Comment by Antonín Juran [ 10/Oct/22 ] |
DISCOVERYUnpublicationCommand#execute method unpublishes specific node on an author instance which causes removing of its counterpart on public instance. If the node contains a child node which hasn't been published yet (i.e. moved node), such child node isn't removed from the public instance. Suggested solution:We could collect child nodes of the unpublished node which haven't been published yet and pass them to the list of nodes which is parameter of Sender#unpublish method called in the UnpublicationCommand#execute. |
| Comment by Roman Kovařík [ 14/Nov/22 ] |
|
Solution: the unpublished children are not published as part of the unpublishing process. This might result in the process taking longer than before. |