[PUBLISHING-63] Publish recursively and modified only is broken Created: 14/Feb/19 Updated: 29/Mar/22 Resolved: 04/Sep/19 |
|
| Status: | Closed |
| Project: | Publishing |
| Component/s: | None |
| Affects Version/s: | 1.1.1 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | High |
| Reporter: | Sebastian Tauch | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Not an issue | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
All |
||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Patch included: |
Yes
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | Support | ||||||||
| Sprint: | Maintenance & Releases | ||||||||
| Story Points: | 1 | ||||||||
| Team: | |||||||||
| Description |
|
Selection of child nodes for recursive+modifiedOnly publications selects the wrong nodes. For some reason the rule selection method is overwritten to NOT use the nodes returned by the RuleBasedNodePredicate and there is no comment as to why this change was made. I have attached a patch with a suggested change. Steps to reproduce:
|
| Comments |
| Comment by Aleksandr Pchelintcev [ 04/Sep/19 ] |
|
Hi stauch, After investigation and some pondering, we decided to not proceed with trying to find a solution to this issue. Even though intuitively the problem statement you provided and the patch may seem legit, however, they conflict with some sensitive logic in publishing mechanism:
In order to achieve the behaviour that you desire, you can alter the configuration of the corresponding action. See e.g. /modules/dam-app/apps/assets/subApps/browser/actions/restorePreviousVersionIncludingChildren: If you desire to handle all the nodes separately disregarding their type - you can leave the allowedTypes node empty. Hope that helps, |
| Comment by Sebastian Tauch [ 04/Sep/19 ] |
|
Hi Aleksandr, that makes sense! Thank you for the detailed explanation. The added documentation in the PR will definitely help the next person who stumbles over this! Looks like I'll have to remove our override and add the allowed nodeTypes for publication the canonical way. Sincerely |