[PUBLISHING-87] Publish a page does not include variants Created: 28/Aug/20  Updated: 26/Jan/24  Resolved: 05/Feb/21

Status: Closed
Project: Publishing
Component/s: None
Affects Version/s: 1.2.1
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Viet Nguyen Assignee: Milan Divilek
Resolution: Won't Fix Votes: 1
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to LIVECOPY-237 Variants are not published Closed
relates to MGNLPN-704 DOC: Describe how editing a Component... Closed
causality
documentation
to be documented by PUBLISHING-98 DOC: Publish behaviour in combination... Closed
relation
is related to PAGES-656 Creating/Editing/Removing a component... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Testcase included:
Yes
Release notes required:
Yes
Date of First Response:
Epic Link: Support
Sprint: Maintenance 43
Story Points: 3
Team: Nucleus

 Description   

Steps to reproduce

  1. Open /travel/contact page and make some changes
  2. Also add a new variant to the page let's say "test" variant
  3. Publish the page (not publish includes subnodes)

Expected results

Pages and its related information got published

Actual results

Only page changes were published, the new variant wasn't

Workaround

Author(s) from Pages editor select the "variants" node and publish it using JCR Browser

Development notes

Notes to/from developers



 Comments   
Comment by Milan Divilek [ 05/Feb/21 ]

We don't want to fix it. Only page and related content(areas, components...) should be published when "publish" action is triggered. This was decided when p13n module was introduced. If we change default behaviour also to publish page variants than we lose flexibility to publish only page itself.
Example: Marketing team prepares page variants for promotion in US, but they are not ready yet and meantime we need change in original page new content/fix typo/... if we change default behaviour for publish action then also the unfinished page variants are published.

The default behaviour for publish can be easily changed by simple modification of publish command:
The default publish command used by pages app is "workflow-activation" which uses the "default-personalizationActivation" command. So we need to add "mgnl:variants" and "mgnl:variant" nodeTypes to the command.
/modules/personalization-core/commands/default/personalizationActivation@itemTypes == "mgnl:contentNode,mgnl:componentVariants,mgnl:variants,mgnl:variant"

Generated at Mon Feb 12 10:35:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.