[QAARQ-41] Improper ACK with Exception handling Created: 30/May/23 Updated: 06/Jun/23 Resolved: 05/Jun/23 |
|
| Status: | Closed |
| Project: | Queued Asynchronous Activation over RabbitMQ |
| Component/s: | connector |
| Affects Version/s: | 1.8 |
| Fix Version/s: | 1.9 |
| Type: | Bug | Priority: | Major |
| Reporter: | Bartosz Gorski | Assignee: | Richard Gange |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 0.75h | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Magnolia 6.2, local RMQ, macOS |
||
| Attachments: |
|
| Template: | |
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
Steps to reproduce
Expected resultsNo errors, the first page is marked as not published and the second page is marked as published Actual resultsPublisher instance errors. Both pages are not marked as published WorkaroundThe custom class which inherit from ConfirmationConsumer class with bugfix Cause(based on decompiled source, line numbers may be wrong) ackMap.keys(); which, when ackMap is null, throws NullPointerException. I suggest changing it to: if(ackMap != null) { Iterator<String> keysIt = ackMap.keys(); if (keysIt.hasNext()) { ... (see attached screens for more detailed info) ackMap is null when message body is '[]', which is ok-ish when public instance exception thrown |
| Comments |
| Comment by Richard Gange [ 05/Jun/23 ] |
|
Hello bgorski- Version 1.9 has been released with code changes you suggested. Please update when you can. Cheers |
| Comment by Bartosz Gorski [ 06/Jun/23 ] |
|
Thank you Richard! I will check it later today |