[RESPDAM-17] Wrong documentation for Pathbuilding Created: 08/Sep/19  Updated: 14/Feb/22  Resolved: 29/Apr/20

Status: Closed
Project: DAM Focal
Component/s: None
Affects Version/s: 1.1.4
Fix Version/s: 1.1.6

Type: Bug Priority: Neutral
Reporter: Wojciech Rydzewski Assignee: Adrien Manzoni
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
clones RESPDAM-13 Building the image url Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Sprint: Sprint 5

 Description   

Documentation states the Asset-Path is supposed to be used. https://documentation.magnolia-cms.com/display/SERVICES/Focal+Points#FocalPoints-BuildtheimageURL

 

But the module itsself uses node-id, hardcoded to jcr: provider

magnolia-dam-images-responsive-1.1.4-sources.jar!/info/magnolia/dam/imaging/responsive/ui/imaging/parameters/AbstractResponsiveParameterProviderFactory.java:85

// Gets the node
Node node = SessionUtil.getNodeByIdentifier(requestParams.getWorkspace(),  requestParams.getAssetId()); 

Resolved in

magnolia-dam-images-responsive-1.1.4-sources.jar!/info/magnolia/dam/imaging/responsive/ui/imaging/parameters/ResponsiveImageRequest.java:82

 // Asset id
this.assetId = StringUtils.substring(element(paths, index++), JCR_PREFIX.length());

 


Generated at Mon Feb 12 00:41:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.