[RESPDAM-83] JCR default values for variations Created: 21/Mar/23  Updated: 23/May/23  Resolved: 23/May/23

Status: Closed
Project: DAM Focal
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4.1

Type: Bug Priority: Medium
Reporter: Philipp Gaschuetz Assignee: Raphael Falvo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to RESPDAM-77 FocalAreas information is not stored ... Closed
relates to RESPDAM-85 Focal point default information is st... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Team: Services
Work Started:

 Description   

info.magnolia.dam.focal.point.observation.FocalPointAssetObservation writes default values (50, 50) for each registered variation into the JCR when a new asset is created.

Generally, I would like to question, whether this approach is the correct way to tackle default values, as it doesn't account for variations added to the definitions after an asset was created.
Without going into depth, FocalPointAdapter seems to be a more suitable location to add default/fallback values on the fly ensuring that consumers always get a focal point value for each registered variation.

Disregarding the usefulness of writing default values to the JCR in general:

  • we have 8 variations registered
  • we have 2500+ PDFs stored in the DAM (and growing)
  • FocalPointAssetObservation writes default values irrespectively of the underlying mimeType
  • in our scenario, this leads to the creation of 22.500+  unnecessary nodes being created

If persisting default values is really necessary, kindly consider adding a condition based on the mimeType/fileType/tika recognized mimeType.

Many thanks!



 Comments   
Comment by Raphael Falvo [ 08/May/23 ]

Resolution of RESPDAM-85 will also solve RESPDAM-83. This will be released in version 2.4.1.

Comment by Raphael Falvo [ 23/May/23 ]

Will be released in version 2.4.1

Generated at Mon Feb 12 00:42:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.