[RESPDAM-88] Operation "responsive" in DamFocalTemplatingFunctions Created: 06/Jul/23  Updated: 12/Jul/23  Resolved: 12/Jul/23

Status: Closed
Project: DAM Focal
Component/s: None
Affects Version/s: 2.4.2
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Marcel Koch Assignee: Raphael Falvo
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Team: Services
Work Started:

 Description   

From my understanding the operation used in this line should be focalpoint and not responsive or even better would be an option to pass the operation as parameter for the case of hot spots:

https://git.magnolia-cms.com/projects/INCUBATOR/repos/dam-focal/browse/magnolia-dam-focal-common/src/main/java/info/magnolia/dam/focal/templating/function/DamFocalTemplatingFunctions.java#46



 Comments   
Comment by Raphael Falvo [ 11/Jul/23 ]

Hello marcel.koch 
The class you are referring to in the description is obsolete, it's a mistake to still have it there.

You shall use the templating function classes that are in each module (focal point, focal area or hotspot), listed below and in the documentation:

https://git.magnolia-cms.com/projects/INCUBATOR/repos/dam-focal/browse/magnolia-dam-foc[…]o/magnolia/dam/focal/area/template/FocalAreaFunctions.java
https://git.magnolia-cms.com/projects/INCUBATOR/repos/dam-focal/browse/magnolia-dam-foc[…]olia/dam/focal/hotspot/template/FocalHotspotFunctions.java
https://git.magnolia-cms.com/projects/INCUBATOR/repos/dam-focal/browse/magnolia-dam-foc[…]magnolia/dam/focal/point/template/FocalPointFunctions.java

Comment by Marcel Koch [ 11/Jul/23 ]

Hej @rfalvo, (why does the user mention macro does not work for me?)

dam( n )! I should have known this. I used the FocalFunctions before and was suprised not to find them in my classpath. Seems like I overlooked them.

Never mind, sorry to bother you.

You can close the issue.

Regards and thanks
Marcel

Comment by Raphael Falvo [ 12/Jul/23 ]

Hi marcel.koch 
Thanks for your feedback, I'm closing the ticket now.
Best Regards

Raphaël

Generated at Mon Feb 12 00:42:25 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.