[SEO-19] Allow RequestFetcher template domain/port to be configured Created: 28/Jun/19 Updated: 13/Sep/19 Resolved: 13/Sep/19 |
|
| Status: | Closed |
| Project: | Search Engine Optimization |
| Component/s: | None |
| Affects Version/s: | 5.6.6 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Bret Lederle | Assignee: | Andrew Warinner |
| Resolution: | Workaround exists | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Magnolia 5.6.11, RHEL7, JBoss EAP 7.2.1 |
||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
The request template is currently set to "http://localhost:8080{0}?mgnlPreview=true&mgnlChannel=desktop" in info.magnolia.services.seo.audit.impl.RequestFetcher.java without any way to update to a different domain/port. There should be a way to configure this string so the feature works in environments that are not localhost:8080. |
| Comments |
| Comment by Andrew Warinner [ 08/Jul/19 ] |
|
Hello Bret, Sorry for the late response, I was off for a few days. RequestFetcher has a "requestTemplate" property that allows you to set the URL template used to make requests (defaults to "http://localhost:8080{0}?mgnlPreview=true&mgnlChannel=desktop").
requestTemplate should be configurable, at least as of v5.6.6 of the module. Have you tried adjusting the configuration of requestTemplate? Kind regards, Andrew Warinner |
| Comment by Bret Lederle [ 09/Jul/19 ] |
|
Thanks Andrew. I had removed the seo app after I wasn't able to get it to work, so I'll reapply the app and test the requestTemplate property you mentioned and get back to you. |