[SEO-34] Use the new pages-app Created: 24/Jan/22  Updated: 20/May/22

Status: Open
Project: Search Engine Optimization
Component/s: None
Affects Version/s: 6.2
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Tobias Kerschbaum Assignee: Chris Jennings
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File image-2022-01-24-15-25-34-243.png    
Issue Links:
Relates
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Steps to reproduce

  1. Install the module
  2. Run a check on a page which fails
  3. Click on the Fix button

.. Logs, screenshots, gifs...

Expected results

Since my Instance uses Magnolia 6.2.15 with the new pages app I would expect to get directed to:

http://localhost:8080/.magnolia/admincentral#app:pages-app:detail;/home_zh_CN:edit

Actual results

http://localhost:8080/.magnolia/admincentral#app:pages:detail;/home_zh_CN:edit

When I click on edit page properties, I get an exception.

Workaround

Development notes

Right now, the app name is hard-coded there:
https://git.magnolia-cms.com/projects/SERVICES/repos/seo/browse/src/main/java/info/magnolia/services/seo/app/rendering/GeneralAuditRenderer.java#65

Not sure if we still have to support the old pages-app. If yes, we could make it configurable. If not, maybe we can quickly update it.



 Comments   
Comment by Chris Jennings [ 20/May/22 ]

Originally fixed in info.magnolia.services.seo.app.rendering.GeneralAuditRenderer and released as 6.2.1 but the same hardcoding is also present in info.magnolia.services.seo.app.rendering.UndefinedPropertyRenderer.

See: https://git.magnolia-cms.com/projects/SERVICES/repos/search-engine-optimization/browse/src/main/java/info/magnolia/services/seo/app/rendering/UndefinedPropertyRenderer.java?at=refs%2Ftags%2Fmagnolia-seo-6.2.1#42

Will fix again and double check for further occurrences.

Comment by Chris Jennings [ 20/May/22 ]

Fixed in 6.2.2. Seeking permissions to create the release here in Jira and update everything.

Generated at Mon Feb 12 10:46:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.