[SHOP-34] In the product app, image tab use a path to indentifier converter in the link field Created: 24/Jun/20  Updated: 09/Oct/20  Resolved: 09/Oct/20

Status: Closed
Project: Shop
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Improvement Priority: Neutral
Reporter: Adrien Manzoni Assignee: Riste Drangovski
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screenshot 2020-06-25_09-56-57-171.png     PNG File image-2020-06-29-09-11-06-406.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: UI
Sprint: Scrum Sprint 2

 Description   

Like it's done here info.magnolia.ui.editor.converter.JcrPathToIdentifierConverter

 

Additionally, the image preview is stretching the image and breaking its ratio.
Could we display the image in its original ratio ?



 Comments   
Comment by Riste Drangovski [ 29/Jun/20 ]

Hi @Adrien Manzoni

We were using default magnolia info.magnolia.shop.ui.field.DamImagePreviewComponent.
It displays image in this way. 
We added some css classes to the component and now images are displayed like in the screenshot below:

Regarding identifierToPathConverter new magnolia link does not support this by default as far as I can see:
https://documentation.magnolia-cms.com/display/DOCS62/Link+field

But we'll see what we can do (maybe implement custom converter class or customize the beanLinkField component).

Regards,
Riste

Generated at Mon Feb 12 10:48:25 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.