[SPARE-7] preview tab button does not work Created: 10/Jan/23  Updated: 22/Feb/23  Resolved: 10/Jan/23

Status: Closed
Project: SPA Rendering Extended
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Sergio Marino Assignee: Unassigned
Resolution: Incomplete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Please read comments from customer:

after bisecting frontend-helpers master branch I found the actual source of our issue - which underlines my initial guess, that magnolia is not notified correctly about change on the frontend.

I found, that our problem arises from frontend-helpers#5528322c51017edc45fab032ebfd1db93bab8830 (before react-editor works fine).

My guess is, that a regression was introduced by removing the line packages/react-editor/src/component/EditablePage/EditablePage.js?f=52 with statement EditorContextHelper.onFrameReady().

Somehow, this method is supposed to inform magnolia about some form of change when the page is running in an iframe, which then is triggering Magnolia to update the preview button with a location url.

After re-adding the code line to the mentioned commit, our problem does not occur anymore. I got the same result, when re-adding the code to the latest commit in branch master.

Maybe you can bring some light into the matter, if this is the correct reasoning, and why this does not happen when running an external SPA?



 Comments   
Comment by Sergio Marino [ 10/Jan/23 ]

wrong project

Generated at Mon Feb 12 11:01:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.