[TASKMGMT-49] Make Newer Constructor In TaskListPresenter Public Created: 19/Feb/21  Updated: 19/Feb/21

Status: Open
Project: Task Management
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Julian Nodarse Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

The new constructor in TaskListPresenter is not public: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/tasks-app/src/main/java/info/magnolia/task/app/TaskListPresenter.java#66

There is a comment saying

    /**
     * @deprecated since 6.2.6, use {@link #TaskListPresenter(GridViewDefinition, ComponentProvider, AvailabilityChecker, TasksManager, TasksDataSourceDefinition, Datasource, TaskDataSourceObservation, Provider, PropertySetFactory)}.
     */

But it is not possible since it is not public.

The constructor in TasksDataProvider calls the new constructor via fetch().

The confusion is with the comment saying to use the new TaskListPresenter constructor. The constructor should be Public, or the comment should be removed.


Generated at Mon Feb 12 11:02:36 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.