[TXTREC-65] Wrong message after deleting all tags Created: 26/Aug/19 Updated: 23/Aug/22 |
|
| Status: | Open |
| Project: | Text Classification |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Julie Legendre | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | maintenance | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Story Points: | 0.5 | ||||||||
| Team: | |||||||||
| Description |
|
To reproduce:
Should rather be something like "All tags deleted successfully." |
| Comments |
| Comment by Evzen Fochr [ 29/Aug/19 ] |
|
Need to check what is happening there, but maybe it is more "Tags were successfully updated." jlegendre? or "Tags were successfully updated for [node-name]." |
| Comment by Julie Legendre [ 29/Aug/19 ] |
|
Hi Evzen, I just realized that you can also add tags in that dialog so I agree that one message (as you suggest above) could be used for both removed or added tags. Node name is nice to have imho. |
| Comment by Chuong Doan Huy [ 30/Aug/19 ] |
|
The message is from content-tag-ui module, not from our TXTREC, so i tried to overwrite it by declaring the key in our "pages-content-tags-integration_en.properties" file. Unfortunately, this doesn't work although TXTREC module loaded after content-tag as expected. After deep debug, i found that our core "DefaultMessageBundlesLoader" coded in a way that we can not override i18n : in loadResourcesInPropertiesMap() method, there is : properties.putAll(existingProperties); => this line mean all existing properties (load first) will override new properties (load later) I don't know if this is accident or intention. Because VN team is off on Monday, if both of you have anytime and want to follow this, please feel free Currently, there is a work-around : changing save action name from "commit" to anything that does not exist from content-tag would work. Thank you |
| Comment by Evzen Fochr [ 30/Aug/19 ] |
|
chuong.doan If I remember right this is intention. Only way you can overwrite i18n is in case of automatic keys (for field labels etc.) and you use more specific key (as add module name as first part). Ill check posibility if we can configure success message for action itself. |