[VANITY-12] Get rid of the STK dependency for Magnolia 5.4 Created: 13/Aug/15  Updated: 24/Nov/15  Resolved: 24/Nov/15

Status: Resolved
Project: Vanity URL app
Component/s: None
Affects Version/s: 1.3.2, 1.4.0
Fix Version/s: 1.4.1

Type: Improvement Priority: Neutral
Reporter: Edgar Vonk Assignee: Frank Sommer
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

HI there,

We would like to use the Vanity URL App in Magnolia 5.4 but we really do not want the STK anymore as it is now obsolete and including it in 5.4 brings on a myriad of issues.

It is possible for you guys to make a version that is compatible with 5.4 and that no longer has a dependency to the STK?

cheers



 Comments   
Comment by Frank Sommer [ 29/Oct/15 ]

Module was upgraded to Magnolia 5.4.2.

The dependency to STK was removed.

Comment by Edgar Vonk [ 29/Oct/15 ]

Thanks Frank!

Comment by Markus Schenk [ 23/Nov/15 ]

Hi there
I was just trying to include your module (1.4.0) in a new 5.4.3 project and it still reports an error during startup

Caused by: info.magnolia.module.model.reader.ModuleDependencyException: The following exceptions were found while checking Magnolia modules dependencies (i.e. those in META-INF/magnolia/my-module.xml):
Module magnolia-vanity-url Magnolia Module (version 1.4.0) is dependent on standard-templating-kit (version ${magnolia.stk.version}/*), which was not found

Here's the maven dependency I used:

    <dependency>
      <groupId>com.aperto.magkit</groupId>
      <artifactId>magnolia-vanity-url</artifactId>
      <version>1.4.0</version>
    </dependency>

Any help appreciated

Comment by Frank Sommer [ 24/Nov/15 ]

Please try 1.4.1-SNAPSHOT

Generated at Mon Feb 12 11:10:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.