[VANITY-17] Internal forwarding Created: 14/Sep/16  Updated: 15/Nov/16  Resolved: 15/Nov/16

Status: Resolved
Project: Vanity URL app
Component/s: None
Affects Version/s: 1.4.1
Fix Version/s: 1.4.2

Type: Improvement Priority: Neutral
Reporter: Niels Hardeman Assignee: Frank Sommer
Resolution: Fixed Votes: 4
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File vanity-url-app-detail-dialog.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Testcase included:
Yes
Date of First Response:

 Description   

Currently the Vanity URL App support two types: redirect (302) and permanent (301).

It would be a great addition to the vanity URL app if it would be able to support a 3rd kind or vanity URL: forward.

This would enable pages to be served directly from their vanity URL. Example:
The URL: http://example.com/interestingpage
would serve out the content found in:
http://example.com/foo/bar/snafu/interestingpage.html



 Comments   
Comment by Niels Hardeman [ 14/Sep/16 ]

Implemented changes and created pull request: https://github.com/aperto/magnolia-vanity-url/pull/8

Comment by Daniel Kasmeroglu [ 06/Nov/16 ]

Hi Frank,

I've checked the Pull-Request from Niels and it works as expected. I suggest to incorporate his Pull-Request although I expect the following modifications:

  • do not add commit 385ff17 as it changes the version number (likely added by accident)
  • the VanityUrlServiceTest adds some unused imports which should be cleaned up

Due to the simplicity of these issues I see no point asking for fixed pull request.

Let me know if you need any additional information.

Comment by Daniel Kasmeroglu [ 08/Nov/16 ]

Regarding my last comment: While looking more thorouhly into the code I discovered the following issues:

  • The forwarding mechanism did not check if the url field contains an UUID. Therefore getting the target node will fail in these cases.
  • If the target node were missing (f.e. in case the page had been deleted) the forward url would point to no destination (forward:)
Comment by Daniel Kasmeroglu [ 08/Nov/16 ]

Hi Frank,

I've created another pull request https://github.com/aperto/magnolia-vanity-url/pull/10 which addresses the aforementioned issues and fixes some error scenarios (plus some additional testcases).

If this pull request gets applied the old pull request 8 can be deleted.

Please let me know if you need some additional information.

Comment by Frank Sommer [ 10/Nov/16 ]

Thx Kasi, I merged your pull request.

Comment by Frank Sommer [ 10/Nov/16 ]

An update task for the dialog change from 1.4.1 to 1.4.2 are still missing.

Comment by Frank Sommer [ 15/Nov/16 ]

Update-Task wurde nun auch hinzugefügt.

Generated at Mon Feb 12 11:10:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.