[VANITY-2] Check compatibilty to Magnolia CE Created: 27/Jun/14  Updated: 05/Jul/18  Resolved: 04/Jul/14

Status: Resolved
Project: Vanity URL app
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2.0

Type: Improvement Priority: Neutral
Reporter: Jan Christian Haddorp Assignee: Frank Sommer
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to VANITY-5 App relies on installed Multi-Site Mo... Resolved
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Visible to:
ameyer, Roland Aust, Werner Rauch

 Description   

The Vanity URL app module is a great idea. But please check compatibilty to Magnolia CE.

After some debugging I think the reason of the incompatibilty is that there is no "default" site in CE release. On CE the following method returns "site".

private String retrieveSite() {
    String siteName = "default";

    AggregationState aggregationState = MgnlContext.getAggregationState();
    if (aggregationState instanceof ExtendedAggregationState) {
        Site site = ((ExtendedAggregationState) aggregationState).getSite();
        siteName = site.getName();
    }

    return siteName;
}

As there is "site" option in the edit dialog things run on an error...

First guess would be one of these options...

  • in CE skip the site selection and use some kind of default behaviour
  • method retrieveSite should simple return "default" if CE

Thanks for an update.



 Comments   
Comment by Frank Sommer [ 27/Jun/14 ]

I thought on CE Magnolia the aggregation state is not an instance of ExtendedAggregationState, so it should be work and delivers always default.

Do you have an error on a Magnolia CE? Can you provide the error message or a screenshot?

Comment by Jan Christian Haddorp [ 27/Jun/14 ]

Interesting point... But our CE edition returns an ExtendedAggregationState instance.
Not sure if this is new in Magnolia or possibly a bug. I will ask Magnolia support.

I don't get an error or any screenshot. The problem is that no matching vanity URL is found. So the request runs on a 404.

Comment by Jan Christian Haddorp [ 27/Jun/14 ]

Please find feedback from Magnolia support regarding EE or CE detection below.

Probably what I would do here is get the ModuleManager and look to see if the enterprise module is installed. If so, EE. If not, CE. There is one possible scenario where you could have it installed but the license isn't valid and thus the system would fall back to CE even though the module exits. Not sure if you care or not about that scenario but I thought I would mention it.
Comment by Moritz Siuts [ 30/Jun/14 ]

I have the same problem (with Magnolia EE). Site is set to "site" and so the mapping is not working at all, because you can't choose "site" when adding vanity-urls.

Comment by Joerg von Frantzius [ 01/Jul/14 ]

Hi Moritz,

this issue is about Magnolia CE compatibility, could you please open a separate issue with steps to reproduce the problem?

Comment by Moritz Siuts [ 01/Jul/14 ]

I need to find some time for the steps to reproduce on a clean project, but then I will open another issue.

Comment by Frank Sommer [ 04/Jul/14 ]

The site retrieving is fixed. Check the multisite module instead of using the extended aggregation state.

Module is successfully tested with 5.2.5 Magnolia CE.

Generated at Mon Feb 12 11:09:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.