[VANITY-4] External link building Created: 30/Jun/14 Updated: 05/Jul/18 Resolved: 16/Oct/14 |
|
| Status: | Resolved |
| Project: | Vanity URL app |
| Component/s: | None |
| Affects Version/s: | 1.2.0 |
| Fix Version/s: | 1.2.2, 1.3.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Jan Christian Haddorp | Assignee: | Frank Sommer |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Visible to: |
ameyer, Roland Aust, Werner Rauch
|
| Description |
|
Please find some thoughts or improvement ideas below...
|
| Comments |
| Comment by Frank Sommer [ 18/Jul/14 ] |
|
The external link building for the publics on the author instance is not so easy to solve. A configurable prefix is an appropriate solution for not multisite environments. On multisite environments we have to solve this in another way. Perhaps by configuring a flag for replacing the contextPath from author by the specific contextPath from public. |
| Comment by Jan Christian Haddorp [ 18/Jul/14 ] |
|
Ok, I understand... I assume it is not so easy to find the perfect solution for all use-cases. So, maybe providing different ways would be perfect.
It is not just the context path. We use different hostnames for author and public instanzes. |
| Comment by Frank Sommer [ 16/Oct/14 ] |
|
The public link creation process is now implemented in an extra service. For custom requirements the service implementation is configurable in the module configuration. For further information see https://github.com/aperto/magnolia-vanity-url#magnolia-module-configuration |