[VANITY-4] External link building Created: 30/Jun/14  Updated: 05/Jul/18  Resolved: 16/Oct/14

Status: Resolved
Project: Vanity URL app
Component/s: None
Affects Version/s: 1.2.0
Fix Version/s: 1.2.2, 1.3.1

Type: Improvement Priority: Neutral
Reporter: Jan Christian Haddorp Assignee: Frank Sommer
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Visible to:
ameyer, Roland Aust, Werner Rauch

 Description   

Please find some thoughts or improvement ideas below...

  • Currently the target URL is rendered as external link. This is not really necessary as this URL shouldn't used as it is (see VANITY-1). The page link can be rendered on time using the stored page ID.
  • External link rendering is only required for the QR code - if you want to save the QR code on the author instance.
  • Currently the link building uses the default URL and removes the context path. This is quite hard coded. We have clients using different host names for author and public. They even have multiple public host names as working behind load balancer.
  • It is fine if the current implementation works for you.
  • But I would like to suggest making a URL prefix configurable on the Vaniry URL app.


 Comments   
Comment by Frank Sommer [ 18/Jul/14 ]

The external link building for the publics on the author instance is not so easy to solve. A configurable prefix is an appropriate solution for not multisite environments. On multisite environments we have to solve this in another way. Perhaps by configuring a flag for replacing the contextPath from author by the specific contextPath from public.

Comment by Jan Christian Haddorp [ 18/Jul/14 ]

Ok, I understand... I assume it is not so easy to find the perfect solution for all use-cases.
Depending on the project setup different approaches may be best.

So, maybe providing different ways would be perfect.

  • As default use the current implementation.
  • Add a optional prefix that can be used instead of the default behaviour.
  • Let the use add a regex or other conditional replacing options.
  • ...

It is not just the context path. We use different hostnames for author and public instanzes.

Comment by Frank Sommer [ 16/Oct/14 ]

The public link creation process is now implemented in an extra service. For custom requirements the service implementation is configurable in the module configuration.

For further information see https://github.com/aperto/magnolia-vanity-url#magnolia-module-configuration

Generated at Mon Feb 12 11:09:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.