<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 03:27:38 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MAGNOLIA-1512] Request charset should be set before any req.getParameter call</title>
                <link>https://jira.magnolia-cms.com/browse/MAGNOLIA-1512</link>
                <project id="10000" key="MAGNOLIA">Magnolia</project>
                    <description>&lt;p&gt;At the moment, the request charset is set using Aggregator.getExtension(), which in turns uses Context.getAttribute. Since the WebContextImpl implementation of getAttribute calls getParameter in case the attribute does not exist on the request, thus making the setCharacterSet call useless - and preventing parameters to be parsed properly (indeed, the container will parse them on the first call to getParam*() with a default encoding - iso-8859-1 in the case of tomcat) &lt;/p&gt;

&lt;p&gt;We might solve this by making the Aggregator.getExtension method (and associated) just using the context attribute - which have to be set previously, for instance by a new filter that has yet to be created.&lt;/p&gt;</description>
                <environment></environment>
        <key id="12779">MAGNOLIA-1512</key>
            <summary>Request charset should be set before any req.getParameter call</summary>
                <type id="2" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10891&amp;avatarType=issuetype">New Feature</type>
                                            <priority id="3" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/major.svg">Major</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="gjoseph">Magnolia International</assignee>
                                    <reporter username="gjoseph">Magnolia International</reporter>
                        <labels>
                    </labels>
                <created>Tue, 8 May 2007 14:32:01 +0200</created>
                <updated>Wed, 23 Jan 2013 08:59:57 +0100</updated>
                            <resolved>Mon, 14 May 2007 10:37:13 +0200</resolved>
                                                    <fixVersion>3.1 M2</fixVersion>
                                    <component>core</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>0</watches>
                                                                                                                <comments>
                            <comment id="13975" author="gjoseph" created="Thu, 10 May 2007 15:22:17 +0200"  >&lt;p&gt;A new filter will (partially) initiliase the Aggregator instance (which will be exposed in the context once &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MAGNOLIA-1523&quot; title=&quot;Aggregator can become a simple bean and be exposed in the context&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MAGNOLIA-1523&quot;&gt;&lt;del&gt;MAGNOLIA-1523&lt;/del&gt;&lt;/a&gt; is fixed) with the basic info from the request&lt;/p&gt;</comment>
                            <comment id="13982" author="gjoseph" created="Thu, 10 May 2007 22:09:35 +0200"  >&lt;p&gt;Actually, with &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MAGNOLIA-1523&quot; title=&quot;Aggregator can become a simple bean and be exposed in the context&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MAGNOLIA-1523&quot;&gt;&lt;del&gt;MAGNOLIA-1523&lt;/del&gt;&lt;/a&gt; cleaning up a number of Aggregator / Path cruft, this could still all happen in the ContentTypeFilter - eventhough it will still be wrong to set the &lt;b&gt;request&apos;s&lt;/b&gt; encoding based on what url is requested, instead of one what page it&apos;s coming from. We could base ourself on the referer&apos;s uri, but that seems unclean, too.&lt;/p&gt;

&lt;p&gt;Normally, the browser should send a character set in the request, and if so, the container SHOULD take into account, only falling back to iso-8859-1 if that&apos;s not the case. It is still unclear what tomcat really does, but I&apos;ve noticed my firefox does not send any charset header in its requests, even if the originating page has meta tags, form enctype attribute etc ...&lt;/p&gt;</comment>
                            <comment id="13988" author="gjoseph" created="Fri, 11 May 2007 20:54:32 +0200"  >&lt;p&gt;done&lt;/p&gt;</comment>
                            <comment id="13990" author="gjoseph" created="Fri, 11 May 2007 22:40:11 +0200"  >&lt;p&gt;reopening: make sure we don&apos;t override any existing charset... there actually ARE ways to make the browser send it! VERY ugly but works: &lt;br/&gt;
&lt;a href=&quot;https://bugzilla.mozilla.org/show_bug.cgi?id=18643&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://bugzilla.mozilla.org/show_bug.cgi?id=18643&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="14000" author="gjoseph" created="Mon, 14 May 2007 10:37:13 +0200"  >&lt;p&gt;fixed: not overriding the request encoding if already set. however, the &lt;br/&gt;
&amp;lt;input type=&quot;hidden&quot; name=&quot;&lt;em&gt;charset&lt;/em&gt;&quot; /&amp;gt; field does not make the browser send an encoding charset within the request headers like i thought it would. All it does it set the value of that field to the encoding used in the page. Since this is very hacky, Id rather not implement support for it in the main magnolia code. If someone really needed this, they could override the setupContentTypeAndCharacterEncoding of ContentTypeFilter.&lt;/p&gt;</comment>
                            <comment id="14021" author="pbracher" created="Tue, 15 May 2007 09:34:03 +0200"  >&lt;p&gt;You could introduce a configurable force encoding flag.&lt;/p&gt;</comment>
                            <comment id="14039" author="gjoseph" created="Tue, 15 May 2007 18:49:10 +0200"  >&lt;p&gt;It is forced, in a sense, now: the request&apos;s char.encoding is going to depend on the requested&apos;uri extension/mimetype.&lt;br/&gt;
It is not set by ContentFilter &lt;b&gt;only&lt;/b&gt; if it is already set (by another 3rd party filter or by the container for instance).&lt;br/&gt;
It wouldn&apos;t make sense to not set it at all (tomcat would use iso-8850-1) since we set it to serve the magnolia pages. (thus the form data is encoded by the browser in that page&apos;s response encoding)&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10020">
                    <name>dependency</name>
                                            <outwardlinks description="depends upon">
                                        <issuelink>
            <issuekey id="12797">MAGNOLIA-1523</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is depended upon by">
                                        <issuelink>
            <issuekey id="12758">MGNLFORUM-15</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 15 May 2007 09:34:03 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            16 years, 41 weeks, 5 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>gjoseph</customfieldvalue>
            <customfieldvalue>pbracher</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i016jr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6943</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>