<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Sun Feb 11 23:51:55 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLCACHE-70] Change flush policy workspace registration</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLCACHE-70</link>
                <project id="10670" key="MGNLCACHE">Cache Modules</project>
                    <description>&lt;p&gt;Change how flush policies are configured: assume we want to flush all repositories by default and only configure exceptions.&lt;/p&gt;</description>
                <environment></environment>
        <key id="40162">MGNLCACHE-70</key>
            <summary>Change flush policy workspace registration</summary>
                <type id="5" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10896&amp;avatarType=issuetype">Sub-task</type>
                            <parent id="37172">MGNLCACHE-55</parent>
                                    <priority id="3" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/major.svg">Major</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="rkovarik">Roman Kova&#345;&#237;k</assignee>
                                    <reporter username="gjoseph">Magnolia International</reporter>
                        <labels>
                    </labels>
                <created>Wed, 13 Aug 2014 17:32:36 +0200</created>
                <updated>Wed, 17 Jun 2015 14:27:07 +0200</updated>
                            <resolved>Wed, 17 Jun 2015 12:52:55 +0200</resolved>
                                                    <fixVersion>5.4</fixVersion>
                                    <component>configuration</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="90024" author="rkovarik" created="Thu, 21 Aug 2014 15:45:58 +0200"  >&lt;p&gt;Migration task preserve compatibility with previous configuration by setting &lt;tt&gt;(newConfiguration/excludedWorkspaces) = (all workspaces \ oldConfiguration/repositories)&lt;/tt&gt;. The result of this update task was used as default configuration.&lt;/p&gt;</comment>
                            <comment id="90047" author="gjoseph" created="Fri, 22 Aug 2014 12:50:51 +0200"  >&lt;p&gt;Re &lt;tt&gt;70457fa3f0059d3fc3a26f17e6481e1b228c74969d&lt;/tt&gt;:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;Use an &lt;tt&gt;@Inject&lt;/tt&gt; annotation&lt;/li&gt;
	&lt;li&gt;Mark your injected dependencies with &lt;tt&gt;final&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;No need to create an &lt;tt&gt;Object[]&lt;/tt&gt; for vararg arguments (log statements)&lt;/li&gt;
	&lt;li&gt;Don&apos;t use stuff like ToStringBuilder.reflectionToString, especially in log statements. The cache key should have its own toString, and if it doesn&apos;t, too bad.&lt;/li&gt;
	&lt;li&gt;info.magnolia.module.cache.AbstractListeningFlushPolicy#start logs twice. Make a single log call, fix message format.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Re &lt;tt&gt;881eb7bac6d657fcf855f71a4f398dd01d97ce41&lt;/tt&gt;&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;Use the &lt;tt&gt;@javax.inject.Inject&lt;/tt&gt; annotation, not Guice&apos;s !&lt;/li&gt;
	&lt;li&gt;Keep &lt;tt&gt;repositoryManager&lt;/tt&gt; &lt;b&gt;private&lt;/b&gt; (and final as noted above)&lt;/li&gt;
	&lt;li&gt;Cleaner for loops: &lt;tt&gt;for (String repo : getRepositories()) {&lt;/tt&gt; (yours like a bastard mixture of while loops mixed with the &quot;foreach&quot; syntax of java 5)&lt;/li&gt;
	&lt;li&gt;If you keep backwards compatibility with the possibility to explicitly list the repos to flush (setRepositories), you should probably have a &lt;b&gt;different&lt;/b&gt; method than &lt;tt&gt;getRepositories&lt;/tt&gt; to produce the final list.
	&lt;ul&gt;
		&lt;li&gt;Separate configuration methods from &quot;business&quot; methods in the class; (I typically put the config methods below with a large &quot;marker&quot; comments (&lt;tt&gt;//--------- config methods below&lt;/tt&gt;), but that&apos;s a matter of style preference, as long as they&apos;re separated)&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
	&lt;li&gt;Don&apos;t inject ModuleRegistry instead of CacheModule; one other, but not necessarily more elegant, solution is to inject a &lt;tt&gt;Provider&amp;lt;CacheModule&amp;gt;&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;typo in name of &lt;tt&gt;testAllRepositoriesExceptExlipcitlyDefined()&lt;/tt&gt;&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Ping me when that&apos;s fixed, i&apos;ll have another look, but looks good otherwise &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/emoticons/smile.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                            <comment id="90111" author="rkovarik" created="Mon, 25 Aug 2014 12:14:01 +0200"  >&lt;blockquote&gt;
&lt;p&gt;Cleaner for loops: for (String repo : getRepositories()) { (yours like a bastard mixture of while loops mixed with the &quot;foreach&quot; syntax of java 5)&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;Is that not correct?&lt;br/&gt;
&lt;a href=&quot;http://docs.oracle.com/javase/specs/jls/se7/html/jls-14.html#jls-14.14.2&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://docs.oracle.com/javase/specs/jls/se7/html/jls-14.html#jls-14.14.2&lt;/a&gt;&lt;br/&gt;
All other pointed issues fixed.&lt;/p&gt;</comment>
                            <comment id="95664" author="rkovarik" created="Fri, 5 Dec 2014 08:11:20 +0100"  >&lt;p&gt;Reopened - remove these workspaces from exclusion:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;These are now wrongly not registered!:
	&lt;ul&gt;
		&lt;li&gt;config&lt;/li&gt;
		&lt;li&gt;forum&lt;/li&gt;
		&lt;li&gt;segments&lt;/li&gt;
		&lt;li&gt;personas&lt;/li&gt;
		&lt;li&gt;scripts&lt;/li&gt;
		&lt;li&gt;usergroups&lt;/li&gt;
		&lt;li&gt;userroles&lt;/li&gt;
		&lt;li&gt;users&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
	&lt;li&gt;These don&apos;t need to be excluded since are not activable:
	&lt;ul&gt;
		&lt;li&gt;messages&lt;/li&gt;
		&lt;li&gt;profiles&lt;/li&gt;
		&lt;li&gt;workflow&lt;/li&gt;
		&lt;li&gt;tasks&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;

</comment>
                            <comment id="98033" author="rkovarik" created="Wed, 28 Jan 2015 13:20:14 +0100"  >&lt;p&gt;Reopened:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;move new functionality to &lt;tt&gt;AbstractFlushListeningPolicy&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;both &lt;tt&gt;workspaces/exludedWorkspaces&lt;/tt&gt; will be supported witch mutual exclusion. (since in &lt;tt&gt;ReferencePageFlushListeningPolicy&lt;/tt&gt;) we need the original behaviour&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;repositories&lt;/tt&gt; will be deprecated&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="98715" author="rkovarik" created="Wed, 11 Feb 2015 12:48:57 +0100"  >&lt;p&gt;Reopened:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;Users needs to be excluded from cache since there are changes in this workspace when any user is logged in.&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="104775" author="rkovarik" created="Mon, 25 May 2015 15:03:27 +0200"  >&lt;p&gt;Reopened: Imaging should not by excluded from cache flush policy by default but by imaging module.&lt;/p&gt;</comment>
                            <comment id="106065" author="rkovarik" created="Mon, 15 Jun 2015 11:27:21 +0200"  >&lt;p&gt;Reopened: &lt;tt&gt;mgnlVersion/mgnlSystem&lt;/tt&gt; is now named &lt;tt&gt;magnolia-mgnlVersion, magnolia-mgnlSystem&lt;/tt&gt;.&lt;/p&gt;</comment>
                            <comment id="106229" author="efochr" created="Wed, 17 Jun 2015 12:06:33 +0200"  >&lt;p&gt;mgnlSystem still there&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10160">
                    <name>Relates</name>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="40251">MGNLCACHE-72</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10020">
                    <name>dependency</name>
                                                                <inwardlinks description="is depended upon by">
                                        <issuelink>
            <issuekey id="43149">MGNLADVCACHE-42</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="43062">MGNLCACHE-83</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 21 Aug 2014 15:45:58 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>false</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ajones</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            8 years, 35 weeks, 4 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>efochr</customfieldvalue>
            <customfieldvalue>gjoseph</customfieldvalue>
            <customfieldvalue>rkovarik</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i03m6v:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>21194</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10220" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Release notes required</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10490"><![CDATA[Yes]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>