<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 00:03:13 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLCMNT-107] pagecommenting per locale and/or per site is not working</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLCMNT-107</link>
                <project id="10310" key="MGNLCMNT">Commenting (closed)</project>
                    <description>&lt;p&gt;Pagecommenting per locale and/or per site is not working; it has several reasons.&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;1st reason: see &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLCMNT-20&quot; title=&quot;Make the commenting module site aware.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLCMNT-20&quot;&gt;&lt;del&gt;MGNLCMNT-20&lt;/del&gt;&lt;/a&gt;; comment from Eric Hechinger,  added a comment - 14/Mar/12 9:16 AM =&amp;gt; /modules/commenting/templates/components/comments/parameters/@forumName should be removed&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;2nd reason: Forum-node (and thread-node, too) here are created on the fly when the page of a certain locale and site are requested for the 1st time; but anonymous-user currently cannot create a forum or a thread (since &quot;simple security model&quot; has been introduced with forum-3.3) ... 
{DefaultForumManager#createForum}
&lt;p&gt; has 2 problems:&lt;/p&gt;
	&lt;ul&gt;
		&lt;li&gt;checking &lt;tt&gt;isModerator(hm, repoRoot)&lt;/tt&gt; will fail (easy to fix ... but probably a sec.-problem)&lt;/li&gt;
		&lt;li&gt;&lt;tt&gt;repoRoot.createContent(cleanName, FORUM_NODETYPE)&lt;/tt&gt; =&amp;gt; will always fail ...  anonymous-user requires more rights&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="38342">MGNLCMNT-107</key>
            <summary>pagecommenting per locale and/or per site is not working</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/critical.svg">Critical</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="cmeier">Christoph Meier</assignee>
                                    <reporter username="cmeier">Christoph Meier</reporter>
                        <labels>
                    </labels>
                <created>Tue, 29 Apr 2014 17:38:19 +0200</created>
                <updated>Thu, 15 May 2014 12:13:02 +0200</updated>
                            <resolved>Wed, 14 May 2014 11:53:32 +0200</resolved>
                                    <version>2.2</version>
                                    <fixVersion>2.2.1</fixVersion>
                                    <component>security</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="84759" author="cmeier" created="Wed, 7 May 2014 18:15:29 +0200"  >&lt;p&gt;After removing the property &lt;em&gt;/modules/commenting/templates/components/comments/parameters/@forumName&lt;/em&gt;  from the config.&lt;br/&gt;
Multi-locale page-commenting works, if the user has appropriate permissions. &lt;/p&gt;

&lt;p&gt;But: Multisite and the combination of multisite and multi-locale enabled fails.&lt;br/&gt;
Reason: Everytime when trying to submit a comment, siteName is evaluated, but this fails:&lt;br/&gt;
&lt;tt&gt;PageComments#determineForumToUse&lt;/tt&gt; line 206&lt;br/&gt;
calls &lt;br/&gt;
&lt;tt&gt;Defaults#determineSiteName&lt;/tt&gt;&lt;br/&gt;
which fails because&lt;br/&gt;
&lt;tt&gt;if (model.getRoot() instanceof STKPageModel)&lt;/tt&gt;  ... is false when the model is of the type &lt;tt&gt;PageComments&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;so ... either &lt;tt&gt;PageComments&lt;/tt&gt; must be adapted in way that it is of type &lt;tt&gt;STKPageModel&lt;/tt&gt; or the implementation of &lt;tt&gt;Defaults#determineSiteName&lt;/tt&gt; must be adapted.&lt;/p&gt;</comment>
                            <comment id="84760" author="cmeier" created="Wed, 7 May 2014 18:20:48 +0200"  >&lt;p&gt;If the above issue is fixed, the current user requires appropriate permissions: &lt;/p&gt;

&lt;ol&gt;
	&lt;li&gt;there must be a role &lt;em&gt;forum-&amp;lt;expected-forum-name&amp;gt;-user&lt;/em&gt;  , e.g. &lt;em&gt;forum-pagecomments_de-user&lt;/em&gt; or &lt;em&gt;pagecomments-demo-project_en&lt;/em&gt; ,etc.&lt;/li&gt;
	&lt;li&gt;that role from (1) must have read/write permissions on the forum-workspace for the path  &lt;em&gt;/&amp;lt;expected-forum-name&amp;gt;&lt;/em&gt;  (and also should have read-permission on the users-workspace on the path &lt;em&gt;/forum-&amp;lt;expected-forum-name&amp;gt;-user&lt;/em&gt; )&lt;/li&gt;
	&lt;li&gt;that role must be granted to anonymous-user (or to those users which should be allowed to read/write comments in the desired multisite- or multi-locale-context)&lt;/li&gt;
&lt;/ol&gt;


&lt;p&gt;AND: To enable multi-site or multi-locale -commenting, the user must remove the property &lt;em&gt;/modules/commenting/templates/components/comments/parameters/forumName&lt;/em&gt;, at least its value must be empty.&lt;br/&gt;
If the property is set, its value is used as the forum-name. For sure there should be a role with read/write permissions  and the role must be granted to anonymous-user (as explained above). &lt;br/&gt;
The default value for this is property is still &lt;em&gt;pagecomments&lt;/em&gt; -  what is compeltly ok.&lt;/p&gt;
</comment>
                            <comment id="85060" author="cmeier" created="Wed, 14 May 2014 11:53:32 +0200"  >&lt;p&gt;Committed onto branch &quot;&lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLCMNT-107&quot; title=&quot;pagecommenting per locale and/or per site is not working&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLCMNT-107&quot;&gt;&lt;del&gt;MGNLCMNT-107&lt;/del&gt;&lt;/a&gt;&quot;&lt;br/&gt;
(See &lt;a href=&quot;https://git.magnolia-cms.com/gitweb/?p=modules/commenting.git;a=commit;h=04eae6b20ae92a28b1b06ef5858eb693e2f5a276&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.magnolia-cms.com/gitweb/?p=modules/commenting.git;a=commit;h=04eae6b20ae92a28b1b06ef5858eb693e2f5a276&lt;/a&gt; )&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10020">
                    <name>dependency</name>
                                            <outwardlinks description="depends upon">
                                        <issuelink>
            <issuekey id="38239">MGNLFORUM-259</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            9 years, 40 weeks, 4 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>cmeier</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i03az3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>19374</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>