<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 00:02:24 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLCMNT-20] Make the commenting module site aware.</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLCMNT-20</link>
                <project id="10310" key="MGNLCMNT">Commenting (closed)</project>
                    <description>&lt;p&gt;The commenting module does not use the website as information to store comments, so the comments&lt;br/&gt;
are global to all sites, this patch adds the option to set a parameter in the paragraph definition (useSiteName)&lt;br/&gt;
to make the commenting module use a forum per website. The forum name is made of the forumName specified&lt;br/&gt;
in the definition and the website name, retrieved from the root node of the content the paragraph is placed in.&lt;/p&gt;

&lt;p&gt;Enabling this does require someone the create the forum called by this, and set the corresponding&lt;br/&gt;
acl&apos; s for the users.&lt;/p&gt;

&lt;p&gt;Attached is the diff containing:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;changes to the bootstrap xml&apos;s for the paragraphs (default not using the site name).&lt;/li&gt;
	&lt;li&gt;changes to the java code of PageComments.java and LatestComments.java&lt;/li&gt;
	&lt;li&gt;a CommentingUtil class containing the method to determine the forum name&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="17813">MGNLCMNT-20</key>
            <summary>Make the commenting module site aware.</summary>
                <type id="4" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10890&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/major.svg">Major</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="10000">Won&apos;t Do</resolution>
                                        <assignee username="-1">Unassigned</assignee>
                                    <reporter username="rico.jansen">Rico Jansen</reporter>
                        <labels>
                            <label>commenting</label>
                            <label>multisite</label>
                            <label>patch</label>
                            <label>vpro</label>
                    </labels>
                <created>Tue, 9 Feb 2010 11:46:19 +0100</created>
                <updated>Thu, 16 Mar 2023 10:18:02 +0100</updated>
                            <resolved>Thu, 16 Mar 2023 10:18:01 +0100</resolved>
                                    <version>1.1</version>
                                    <fixVersion>1.2.x</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>0</watches>
                                                                                                                <comments>
                            <comment id="27720" author="had" created="Wed, 31 Mar 2010 09:50:03 +0200"  >&lt;p&gt;Hey Rico,&lt;br/&gt;
thanks for the patch and sorry I missed it earlier. I&apos;ll look at soon.&lt;br/&gt;
Jan&lt;/p&gt;</comment>
                            <comment id="27727" author="rico.jansen" created="Wed, 31 Mar 2010 14:07:31 +0200"  >&lt;p&gt;No problem, the next site which will use commenting where this would be handy will probably be&lt;br/&gt;
launched around the beginning of June.&lt;/p&gt;</comment>
                            <comment id="27742" author="had" created="Wed, 31 Mar 2010 17:04:13 +0200"  >&lt;p&gt;Few technical comments on the patch itself:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;in the patch you forgot unused &lt;tt&gt;LatestComments.getForumName()&lt;/tt&gt; method which you have presumably moved to the newly created &lt;tt&gt;CommentingUtil&lt;/tt&gt; class.&lt;/li&gt;
	&lt;li&gt;in the &lt;tt&gt;LatestComments&lt;/tt&gt; class you have also removed &lt;tt&gt;getPageLink()&lt;/tt&gt; method which breaks the &lt;tt&gt;latestComments.ftl&lt;/tt&gt; template at line 13. Was that just an oversight or you forgot to include updated template in the patch?&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;The patch hardcodes the &lt;tt&gt;forumName-siteName&lt;/tt&gt; pattern for the comments forum name and introduces new flag (&lt;tt&gt;false&lt;/tt&gt; by default) whether to suffix &lt;tt&gt;forumName&lt;/tt&gt; with site name or not. That on its own is fine. However when enabling the feature, such forum still needs to be created manually and appropriate roles need to be generated and assigned. &lt;br/&gt;
It seems more appropriate to have such configuration in the configuration of the commenting module rather then in the paragraph definition and using observation to generate appropriate forum and roles for each site when enabled.&lt;br/&gt;
Furthermore, commenting already allows to specify forum name (although it is not automatically site aware) and using &lt;tt&gt;extends&lt;/tt&gt; feature of Magnolia 4.3 you can easily create one paragraph definition per site which would use specific forum for the site (without limiting yourself to any kind of pattern). Then in each &lt;tt&gt;&amp;lt;site&amp;gt;/templates/prototype/main/commenting/paragraph&lt;/tt&gt; configuration node (or in whichever other template you use this paragraph) you can point to the paragraph configuration that is appropriate for given site. This gives you basically same functionality as the one provided by the patch (ability to use one forum per site, with having to create such forum and configure roles manually).&lt;/p&gt;

&lt;p&gt;Do you think you can improve the patch along the lines of automatic creation of forums and roles per site when site awareness is turned on?&lt;/p&gt;</comment>
                            <comment id="27758" author="rico.jansen" created="Thu, 1 Apr 2010 09:45:34 +0200"  >&lt;p&gt;Point 1: An oversight definetly&lt;br/&gt;
Point 2: That would be a mistake, I haven&apos;t touched the ftl&apos;s at all.&lt;/p&gt;

&lt;p&gt;As for the forum name specifying, yes I became aware of that later, so I didn&apos;t consider it when making&lt;br/&gt;
this solution. As for the configuration in the module instead of the paragraph, I did that to minimize&lt;br/&gt;
the impact, with configuration in the module the setting would be global for all sites. That is  a choice&lt;br/&gt;
that must be made. &lt;/p&gt;

&lt;p&gt;Extending wasn&apos;t there yet unfortunately, but creating a paragraph per site is something we try to&lt;br/&gt;
avoid.&lt;/p&gt;

&lt;p&gt;Auto creation of forums I have considered, but not by observation though, that is an area I haven&apos;t&lt;br/&gt;
looked at much. You are suggesting, that when someone turns on site awareness, that the module&lt;br/&gt;
creates the appropiate forum for all websites and when websites are created. That is possible but&lt;br/&gt;
I am strapped for time the coming month or so.&lt;/p&gt;</comment>
                            <comment id="31424" author="gjoseph" created="Mon, 29 Nov 2010 14:46:53 +0100"  >&lt;p&gt;Finally applied this patch! &lt;br/&gt;
Well, an adapted version of it. Combined with &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLCMNT-34&quot; title=&quot;i18n-aware commenting&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLCMNT-34&quot;&gt;&lt;del&gt;MGNLCMNT-34&lt;/del&gt;&lt;/a&gt;, we now have site-aware and i18n-commenting. Forums are created &quot;on demand&quot;, i.e when a comment is added.&lt;/p&gt;

&lt;p&gt;Do you guys have any use for this &quot;useSiteName&quot; parameter you introduced, or is it just to avoid breaking existing installs ? In &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLCMNT-35&quot; title=&quot;Do we need to keep support for forum names set in paragraph definitions ?&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLCMNT-35&quot;&gt;&lt;del&gt;MGNLCMNT-35&lt;/del&gt;&lt;/a&gt;, I question the need for the forumName to even be configured in the various paragraphs, since it is now &quot;generated&quot; with site/locale information (i tried and failed to come up with a solution to generate those from the config object, based on a pattern, so the name pattern itself is now hardcoded)&lt;/p&gt;</comment>
                            <comment id="31431" author="rico.jansen" created="Mon, 29 Nov 2010 15:47:10 +0100"  >&lt;p&gt;It was purely for protection against breaking existing installs. So you could keep the old&lt;br/&gt;
behaviour. That was born out of the inability to rename the forum after creation, otherwise&lt;br/&gt;
you could just rename it to the new name.&lt;/p&gt;</comment>
                            <comment id="45419" author="ehechinger" created="Wed, 14 Mar 2012 09:16:51 +0100"  >&lt;p&gt;Currently with EE, this is not working, simply because we still have the property forumName (= pagecomments) defined under &lt;br/&gt;
commenting/templates/components/comments/parameters&lt;/p&gt;

&lt;p&gt;In PageComments.determineForumToUse() the forumName = the property defined prefiously. If it&apos;s not defined, this value will be pagecomments-demo-project_en.&lt;/p&gt;

&lt;p&gt;It seems for me that we have with EE the simple site behavior of CE (we could simply remove the commenting/templates/components/comments/parameters property when installing EE). &lt;/p&gt;</comment>
                            <comment id="348253" author="JIRAUSER22648" created="Thu, 16 Mar 2023 10:18:02 +0100"  >&lt;p&gt;Closing due to project being archived.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10020">
                    <name>dependency</name>
                                            <outwardlinks description="depends upon">
                                        <issuelink>
            <issuekey id="19072">MGNLCMNT-27</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="19419">MGNLCMNT-33</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10010">
                    <name>relation</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="19424">MGNLCMNT-34</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="13030" name="commenting.diff" size="11064" author="rico.jansen" created="Tue, 9 Feb 2010 11:46:19 +0100"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>vpro.nl</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 31 Mar 2010 09:50:03 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ajones</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            47 weeks, 3 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>ajones</customfieldvalue>
            <customfieldvalue>ehechinger</customfieldvalue>
            <customfieldvalue>had</customfieldvalue>
            <customfieldvalue>gjoseph</customfieldvalue>
            <customfieldvalue>rico.jansen</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Patch included</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10100"><![CDATA[Yes]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i02kwv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>15126</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>