<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 00:03:06 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLCMNT-94] make sure commenting works with anonymous user</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLCMNT-94</link>
                <project id="10310" key="MGNLCMNT">Commenting (closed)</project>
                    <description>&lt;p&gt;Commenting requires the role &quot;forum-pagecomments-user&quot;. Add this to user anonymous to ensure he is able to comment.&lt;/p&gt;</description>
                <environment></environment>
        <key id="36384">MGNLCMNT-94</key>
            <summary>make sure commenting works with anonymous user</summary>
                <type id="3" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10898&amp;avatarType=issuetype">Task</type>
                                            <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="cmeier">Christoph Meier</assignee>
                                    <reporter username="cmeier">Christoph Meier</reporter>
                        <labels>
                    </labels>
                <created>Tue, 4 Feb 2014 16:01:30 +0100</created>
                <updated>Mon, 3 Mar 2014 10:43:25 +0100</updated>
                            <resolved>Wed, 19 Feb 2014 15:36:58 +0100</resolved>
                                                    <fixVersion>2.2</fixVersion>
                                    <component>security</component>
                    <component>VersionHandler</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="79171" author="cmeier" created="Tue, 4 Feb 2014 20:13:07 +0100"  >&lt;p&gt;Added  role forum-pagecomments-user to anonymous-user, but:&lt;br/&gt;
anonymous-user can add comments, but cannot see them. To see the comments, the user must be logged in. &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/emoticons/sad.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                            <comment id="79330" author="cmeier" created="Fri, 7 Feb 2014 18:27:54 +0100"  >&lt;p&gt;Probably a caching problem; ReferencedPageFlushPolicy or super-class not working properly.&lt;/p&gt;</comment>
                            <comment id="79606" author="cmeier" created="Thu, 13 Feb 2014 10:00:07 +0100"  >&lt;p&gt;Defintely a caching problem; ReferencedPageFlushPolicy or super-class not working properly.&lt;br/&gt;
(Beside the fact that it also triggered too late.)&lt;br/&gt;
The page seems to be cached at the very first time, when there is no comment on it, after that is always served from cache; even if somebody added comment(s).&lt;br/&gt;
Adding a comment tiggers an event which is treated in ReferencedPageFlushPolicy which should result in flushing that page; but the flushing fails all the time. &lt;/p&gt;


&lt;p&gt;If somebody wants to tackle this one: startt debuging in ReferencedPageFlushPolicy#handleSingleEvent,&lt;br/&gt;
follow the track to AbstractListeningFlushPolicy#flushByUUID; there, size of Object[] cacheEntryKeys is lways 0; so flushing never works.&lt;br/&gt;
Going deeper show, that in info.magnolia.module.cache.cachepolicy.Default private method getUUIDKeySetFromCacheSafely has very strange impl. ... here is one of th reasons, why Object[] cacheEntryKeys.size is always 0.&lt;/p&gt;

&lt;p&gt;I also tried to flush the page from PageComments (the model of the template which renders the commenting-messages), but was not able to do so.&lt;/p&gt;</comment>
                            <comment id="79818" author="cmeier" created="Mon, 17 Feb 2014 19:09:12 +0100"  >&lt;p&gt;Since  &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLCACHE-54&quot; title=&quot;CLONE - uuid-cache key mapping is not updated&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLCACHE-54&quot;&gt;&lt;del&gt;MGNLCACHE-54&lt;/del&gt;&lt;/a&gt; is fixed now, flushing from cache the page with the comments now works,&lt;br/&gt;
but it occurs too late, ReferencedPageFlushPolicy is triggered too late.&lt;br/&gt;
To see the changes, a user must reload the page again to see his latest comment.&lt;/p&gt;</comment>
                            <comment id="79840" author="cmeier" created="Tue, 18 Feb 2014 15:49:39 +0100"  >&lt;p&gt;I&apos;ll set this one to resolved to integrate the other work which was done here (adding the appr. role to anonymous).&lt;br/&gt;
The still remaining bug is now in a follow-up-ticket: &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLCMNT-97&quot; title=&quot;Flushing cache after commenting is triggered too late&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLCMNT-97&quot;&gt;&lt;del&gt;MGNLCMNT-97&lt;/del&gt;&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="79842" author="ejervidalo" created="Tue, 18 Feb 2014 16:04:25 +0100"  >&lt;p&gt;remove all the commented lines in CommentingModuleVersionHandler&lt;/p&gt;</comment>
                            <comment id="79896" author="rkovarik" created="Wed, 19 Feb 2014 14:11:23 +0100"  >&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
                &lt;span class=&quot;code-keyword&quot;&gt;try&lt;/span&gt; {
                    usersSession = installContext.getJCRSession(RepositoryConstants.USERS);
                    userRolesSession = installContext.getJCRSession(RepositoryConstants.USER_ROLES);
                    anonymousUserNode = usersSession.getRootNode().getNode(&lt;span class=&quot;code-quote&quot;&gt;&quot;system/anonymous&quot;&lt;/span&gt;);
                    forumPpagecommentsUser_role_node =  userRolesSession.getRootNode().getNode(&lt;span class=&quot;code-quote&quot;&gt;&quot;forum-pagecomments-user&quot;&lt;/span&gt;);

                } &lt;span class=&quot;code-keyword&quot;&gt;catch&lt;/span&gt; (Exception ex) {
                    installContext.warn(&lt;span class=&quot;code-quote&quot;&gt;&quot;Exception &lt;span class=&quot;code-keyword&quot;&gt;while&lt;/span&gt; trying to add role forum-pagecomments-user to anonymous; &quot;&lt;/span&gt;+ex.getLocalizedMessage());
                }
                &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; anonymousUserNode!=&lt;span class=&quot;code-keyword&quot;&gt;null&lt;/span&gt; &amp;amp;&amp;amp; forumPpagecommentsUser_role_node!=&lt;span class=&quot;code-keyword&quot;&gt;null&lt;/span&gt;;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;That&apos;s not the right way how to check if &lt;tt&gt;anonymous&lt;/tt&gt; user / &lt;tt&gt;forum-pagecomments-user&lt;/tt&gt; role exists, you should use &lt;tt&gt;info.magnolia.cms.security.RoleManager.getRole(String)/ UserManager.getAnonymousUser()&lt;/tt&gt; to get such information&lt;/p&gt;

&lt;p&gt;That code should be replaced, but couple of hints for next time:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;You can use &lt;tt&gt;NodeExistDelegateTask&lt;/tt&gt; for checking of node existence in version handlers, no need to create new &lt;tt&gt;ConditionalDelegateTask&lt;/tt&gt;.&lt;/li&gt;
	&lt;li&gt;You should use session.nodeExists(), not session.getNode() and catch exception if you need to check node existence.&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;forumPpagecommentsUser_role_node&lt;/tt&gt; we try to not use underscores in variables&lt;/li&gt;
&lt;/ol&gt;
</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10040">
                    <name>causality</name>
                                                                <inwardlinks description="is causing">
                                        <issuelink>
            <issuekey id="36985">MGNLCMNT-99</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10020">
                    <name>dependency</name>
                                            <outwardlinks description="depends upon">
                                        <issuelink>
            <issuekey id="36532">MGNLCACHE-54</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10010">
                    <name>relation</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="36618">MGNLCMNT-97</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="22695">MGNLCMNT-57</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 18 Feb 2014 16:04:25 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>false</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            10 years, 4 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>cmeier</customfieldvalue>
            <customfieldvalue>ejervidalo</customfieldvalue>
            <customfieldvalue>rkovarik</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i032a7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>17955</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14167" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Task DoR</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>