<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 01:48:04 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLETK-57] ETKSiteManager in use with domain mappings: should return currentSite if no explicit repository mapping was detected.</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLETK-57</link>
                <project id="10290" key="MGNLETK">Extended Templating Kit (closed)</project>
                    <description>&lt;p&gt;Situation:&lt;br/&gt;
The STK homepage defines the logo and the print logo. In demo project they are chosen from DMS.&lt;br/&gt;
When accessing the demo by the mapped domain name (&lt;a href=&quot;http://demo-project-author.magnolia-cms.com/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://demo-project-author.magnolia-cms.com/&lt;/a&gt;), the logo is not displayed anymore.&lt;br/&gt;
The code starting point is the call getAssetLink(content, nodeDataPrefix, DAMSupport.VARIATION_ORIGINAL);&lt;br/&gt;
So it will serve the image directly from DMS and not from the imaging repo/module.&lt;/p&gt;

&lt;p&gt;when looking at the rendered URL, it created an external link based on the defaultBaseURL, see print screen.&lt;/p&gt;

&lt;p&gt;Cause:&lt;br/&gt;
1. No specific DMS mapping is defined for any site -&amp;gt; the ETKSiteManager falls back to default (instead of current)&lt;br/&gt;
2. default site has no domain mapping -&amp;gt; fallback to the DomainNamePathTransformer which uses the defaultBaseURL&lt;/p&gt;

&lt;p&gt;Correction:&lt;br/&gt;
When no explicit repository mapping in a siteDefinition can be detected, it means that the &apos;requested&apos; content belongs to all. So the ETKSiteManager should return the current-site and not the default-site.&lt;br/&gt;
(Included draft patch created together with Philipp)&lt;/p&gt;</description>
                <environment></environment>
        <key id="20800">MGNLETK-57</key>
            <summary>ETKSiteManager in use with domain mappings: should return currentSite if no explicit repository mapping was detected.</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/critical.svg">Critical</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="pbaerfuss">Philipp B&#228;rfuss</assignee>
                                    <reporter username="cringele">Christian Ringele</reporter>
                        <labels>
                    </labels>
                <created>Thu, 26 May 2011 14:25:49 +0200</created>
                <updated>Tue, 23 Aug 2011 10:17:31 +0200</updated>
                            <resolved>Wed, 17 Aug 2011 16:35:22 +0200</resolved>
                                    <version>1.4.2</version>
                                    <fixVersion>1.4.3</fixVersion>
                                    <component>multisite</component>
                        <due></due>
                            <votes>1</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="35836" author="cringele" created="Thu, 26 May 2011 14:29:06 +0200"  >&lt;p&gt;Was created by solving ETK-49&lt;/p&gt;</comment>
                            <comment id="35846" author="cringele" created="Thu, 26 May 2011 15:35:20 +0200"  >&lt;p&gt;Added better draft patch, old patch was not very smart.&lt;/p&gt;</comment>
                            <comment id="35856" author="had" created="Thu, 26 May 2011 15:57:28 +0200"  >&lt;p&gt;The way i read this patch it will solve the problem for global resources such as dms content, but at a same time it breaks all the global website content which doesn&apos;t belong to any site (such as custom 404 pages, etc.) since with the patch Magnolia will try to read it from the current site and either fetch wrong content or end up with 404.&lt;br/&gt;
Might be better to write and attach test case exposing the problem then half baked patch &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/emoticons/wink.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                            <comment id="35865" author="cringele" created="Thu, 26 May 2011 16:32:53 +0200"  >&lt;p&gt;That is right, don&apos;t use this patch, was just a quick draft.&lt;br/&gt;
I&apos;ll add a test case next time.&lt;/p&gt;</comment>
                            <comment id="35882" author="pbaerfuss" created="Fri, 27 May 2011 08:40:12 +0200"  >&lt;p&gt;There is actually a working workaround:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;add an explicit mapping even for the root pathes (dms --&amp;gt; /)&lt;/li&gt;
	&lt;li&gt;make sure you add it to all the sites&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;The mechanism is then accepting the current site as wished.&lt;/p&gt;</comment>
                            <comment id="35883" author="pbaerfuss" created="Fri, 27 May 2011 08:42:05 +0200"  >&lt;p&gt;A better fix might not only iterate on the direct mappings but also on the indirect ones (the mappings in the central uri mapping). If done so we don&apos;t have to change the algorithm.&lt;/p&gt;</comment>
                            <comment id="36892" author="pbaerfuss" created="Wed, 29 Jun 2011 09:04:25 +0200"  >&lt;p&gt;Scheduling this issue for the next bug fix release. We know how to fix it.&lt;/p&gt;</comment>
                            <comment id="38553" author="pbaerfuss" created="Tue, 23 Aug 2011 10:17:31 +0200"  >&lt;p&gt;Will finally be solved by a new algorithm (&lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLETK-62&quot; title=&quot;multisite detection: implement a rule based algorithm to make the outcome more predictable.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLETK-62&quot;&gt;&lt;del&gt;MGNLETK-62&lt;/del&gt;&lt;/a&gt;).&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10040">
                    <name>causality</name>
                                            <outwardlinks description="caused by">
                                        <issuelink>
            <issuekey id="19994">MGNLETK-49</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is causing">
                                                        </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10010">
                    <name>relation</name>
                                            <outwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="18554">MGNLETK-31</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="21063">MGNLETK-59</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10022">
                    <name>supersession</name>
                                                                <inwardlinks description="is superseded by">
                                        <issuelink>
            <issuekey id="21443">MGNLETK-62</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="14662" name="ETKSiteManager.java.patch" size="2566" author="cringele" created="Thu, 26 May 2011 15:35:20 +0200"/>
                            <attachment id="14660" name="LogoURL.png" size="231088" author="cringele" created="Thu, 26 May 2011 14:25:49 +0200"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 26 May 2011 15:57:28 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            12 years, 26 weeks, 5 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>cringele</customfieldvalue>
            <customfieldvalue>had</customfieldvalue>
            <customfieldvalue>pbaerfuss</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Patch included</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10100"><![CDATA[Yes]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i009cf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1550</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>